Merge pull request DefectDojo#3404 from mgm-sp/close-engagement-error

devGregA · web-flow · commit 7eab116bd4aa · 2020-12-03T22:10:37.000-06:00
Fix Internal Server Error when closing engagements
diff --git a/dojo/jira_link/helper.py b/dojo/jira_link/helper.py
@@ -736,8 +736,12 @@ def close_epic(eng, push_to_jira):
         if push_to_jira:
             try:
                 jissue = get_jira_issue(eng)
+                if jissue is None:
+                    logger.warn("JIRA close epic failed: no issue found")
+                    return False
+
                 req_url = jira_instance.url + '/rest/api/latest/issue/' + \
-                    j_issue.jira_id + '/transitions'
+                    jissue.jira_id + '/transitions'
                 json_data = {'transition': {'id': jira_instance.close_status_key}}
                 r = requests.post(
                     url=req_url,
