[Generic parser] Add more unit tests (DefectDojo#4354)

damiencarol · web-flow · commit 68f459600823 · 2021-04-25T17:14:55.000+02:00
diff --git a/dojo/unittests/scans/generic/generic_report1.csv b/dojo/unittests/scans/generic/generic_report1.csv
@@ -0,0 +1,6 @@
+Date,Title,CweId,Url,Severity,Description,Mitigation,Impact,References,Active,Verified,FalsePositive,Duplicate
+28/02/2021,ASDF,1,https://vulnerable.endpoint.com/resource1/asdf,Low,Some description,Some mitigation advice,Some Impact,,TRUE,TRUE,FALSE,FALSE
+28/02/2021,ASDF,2,https://vulnerable.endpoint.com/resource2/qwerty,Low,Some description,Some mitigation advice,Some Impact,,TRUE,TRUE,FALSE,FALSE
+28/02/2021,ASDF,3,https://vulnerable.endpoint.com/resource3/asdf,Low,Some description,Some mitigation advice,Some Impact,,TRUE,TRUE,FALSE,FALSE
+28/02/2021,ASDF,4,https://vulnerable.endpoint.com/resource4/asdf,Low,Some description,Some mitigation advice,Some Impact,,TRUE,TRUE,FALSE,FALSE
+28/02/2021,ASDF,5,https://vulnerable.endpoint.com/resource5/asdf,Low,Some description,Some mitigation advice,Some Impact,,TRUE,TRUE,FALSE,FALSE
diff --git a/dojo/unittests/tools/test_generic_parser.py b/dojo/unittests/tools/test_generic_parser.py
@@ -23,6 +23,21 @@ def setUp(self):
                                      product=self.product)
         self.test = Test(engagement=self.engagement)
 
+    def test_parse_report1(self):
+        file = open("dojo/unittests/scans/generic/generic_report1.csv")
+        parser = GenericParser()
+        findings = parser.get_findings(file, self.test, True, True)
+        self.assertEqual(1, len(findings))
+        finding = findings[0]
+        self.assertEqual(5, len(finding.unsaved_endpoints))
+        endpoint = finding.unsaved_endpoints[0]
+        self.assertEqual("vulnerable.endpoint.com:443", endpoint.host)
+        self.assertEqual("resource1/asdf", endpoint.path)
+        endpoint = finding.unsaved_endpoints[1]
+        self.assertEqual("vulnerable.endpoint.com:443", endpoint.host)
+        self.assertEqual("resource2/qwerty", endpoint.path)
+        self.assertEqual("https", endpoint.protocol)
+
     def test_parse_no_csv_content_no_findings(self):
         findings = ""
         file = TestFile("findings.csv", findings)
