Fixes UTF-8 issues when computing Hashes

adracea · web-flow · commit 921e99a57234 · 2019-04-04T12:32:57.000+03:00
Fixes an issue where reports containing certain characters were not being properly decoded by `str(self.description)` Waiting for @madchap to also confirm that snyk reports are coming in nicely with these changes .
diff --git a/dojo/models.py b/dojo/models.py
@@ -1078,7 +1078,7 @@ class Meta:
         ordering = ('numerical_severity', '-date', 'title')
 
     def compute_hash_code(self):
-        hash_string = self.title + str(self.cwe) + str(self.line) + str(self.file_path) + str(self.description).decode('utf-8')
+        hash_string = self.title + str(self.cwe) + str(self.line) + str(self.file_path) + self.description
 
         if self.dynamic_finding:
             endpoint_str = u''
@@ -1091,8 +1091,7 @@ def compute_hash_code(self):
             return hashlib.sha256(hash_string.encode('utf-8')).hexdigest()
         except:
             hash_string = hash_string.strip()
-
-        return hashlib.sha256(hash_string).hexdigest()
+            return hashlib.sha256(hash_string).hexdigest()
 
 
     def duplicate_finding_set(self):
