main(helm): chart linting - specify target branch for all ct (DefectDojo#4412)

madchap · web-flow · commit bea0f43a27a6 · 2021-05-02T21:56:40.000+02:00
Missed some stuff, testing in my fork (probably not all cases, but good enough I'd say).

Against master for immediate effect
diff --git a/.github/workflows/test-helm-chart.yml b/.github/workflows/test-helm-chart.yml
@@ -37,28 +37,31 @@ jobs:
       - name: Set up chart-testing
         uses: helm/chart-testing-action@v2.0.1
 
-      - name: Run chart-testing (list-changed)
-        id: list-changed
+      - name: Determine target branch
+        id: ct-branch-target
         run: |
           if [ ! -z ${GITHUB_BASE_REF} ]; then
-            echo "pull_request: ct list-changed --config ct.yaml --target-branch ${GITHUB_BASE_REF}"
-            changed=$(ct list-changed --config ct.yaml --target-branch ${GITHUB_BASE_REF})
+            echo ::set-output name=ct-branch::${GITHUB_BASE_REF}
           else
-            echo "push: ct list-changed --config ct.yaml --target-branch ${GITHUB_REF#refs/heads/}"
-            changed=$(ct list-changed --config ct.yaml --target-branch ${GITHUB_REF#refs/heads/})
+            echo ::set-output name=ct-branch::${GITHUB_REF#refs/heads/}
           fi
+
+      - name: Run chart-testing (list-changed)
+        id: list-changed
+        run: |
+          changed=$(ct list-changed --config ct.yaml --target-branch ${{ steps.ct-branch-target.outputs.ct-branch}})
           if [[ -n "$changed" ]]; then
             echo "::set-output name=changed::true"
           fi
 
       - name: Run chart-testing (lint)
-        run: ct lint --config ct.yaml
+        run: ct lint --config ct.yaml --target-branch ${{ steps.ct-branch-target.outputs.ct-branch }}
         if: steps.list-changed.outputs.changed == 'true'
 
       - name: Create kind cluster
         uses: helm/kind-action@v1.1.0
         if: steps.list-changed.outputs.changed == 'true'
 
       - name: Run chart-testing (install)
-        run: ct install
+        run: ct install --config ct.yaml --target-branch ${{ steps.ct-branch-target.outputs.ct-branch }}
         if: steps.list-changed.outputs.changed == 'true'
