| commit | 2623e05c253c4490e7aa2832fd27352fc3e3496b | [log] [tgz] |
|---|---|---|
| author | Fred Mello <[email protected]> | Wed Oct 02 20:18:04 2019 |
| committer | Commit Bot <[email protected]> | Wed Oct 02 20:18:04 2019 |
| tree | 95a4822355b1c97c569ac3137e74b45f4247d3f3 | |
| parent | 06d698e438c6ab9ac7a60aa8cf1e32fba1d71f92 [diff] |
Android: Refactor Module Installer for Testability The intrinsic dependencies encountered along the way made it difficult (less effective) to break up this CL into multiple smaller CLs (apologies to the reviewers in advance). To simplify its understanding, please refer to the following doc: https://docs.google.com/document/d/1ClZglFQroV53zSYEGIZ7yca8KIsPHGBmzMCbtreu5lg The following are the major points to review: - refactoring of the infra into builder, installer, logger, observer, util - new design (IoC driven) for installers to enable for easy testability - new design for emitted modules (cross-package communication) Out-of-scope (following CLs): - removal of bytecode processing for third-party activities (no longer needed) - move code from ModuleInstallerConfig.java into BuildConfig.java - unit tests for the remaining module_installer classes Testing: this change was verified with vr, ar, autofill_assistant, dev_ui, and test_dummy modules. It was tested with both -m and -f command line args. Bug: 1005802 Change-Id: Icf357c06c4b71a96ed9fa0584f6322d6dc6143d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813520 Reviewed-by: Ilya Sherman <[email protected]> Reviewed-by: Tibor Goldschwendt <[email protected]> Reviewed-by: Andrew Grieve <[email protected]> Reviewed-by: Peter Wen <[email protected]> Commit-Queue: Fred Mello <[email protected]> Cr-Commit-Position: refs/heads/master@{#702165}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .