commit | 8373f041635205aa34164129a389941c774feccb | [log] [tgz] |
---|---|---|
author | Florian Jacky <[email protected]> | Wed Apr 16 14:20:53 2025 |
committer | Chromium LUCI CQ <[email protected]> | Wed Apr 16 14:20:53 2025 |
tree | b2568ce307131a3e779771b9401e2a1579f792fd | |
parent | e86c29db18ed76c51f41314e5e7c28733e1bf284 [diff] |
Reland "[PermissionOptions] Use PermissionDescriptorPtr in PermissionControllerDelegate" This reverts commit d0da8f7e4b866502cb48f9b79868f976be33c042. Reason for revert: Fix CastPermissionManager Bug: 394547183, 393053278 Original change's description: > Revert "[PermissionOptions] Use PermissionDescriptorPtr in PermissionControllerDelegate" > > This reverts commit e116ae4b94a5c9344be3c6ef021ed3e22355811f. > > Reason for revert: cause build failed: https://ci.chromium.org/ui/p/chromium/builders/ci/android-cast-arm64-dbg/6828/overview > > Bug: 394547183, 393053278 > Original change's description: > > [PermissionOptions] Use PermissionDescriptorPtr in PermissionControllerDelegate > > > > This is part of a larger change to support permission options. Permissions with options can no longer be represented by a simple PermissionType enum value, hence the permission infrastructure will start relying on PermissionDescriptorPtrs instead of PermissionTypes. > > > > To reduce the complexity of this CL, it limits the scope of the interface changes to PermissionControllerDelegate, its children and their usages, and uses utility mapping functions to map from PermissionType to PermissionRequestDescriptionPtr, i.e. it does not yet modify the infrastructure itself yet to fully rely on PermissionRequestDescriptorPtr. > > > > Since all ContentSetting permission types currently map to exactly one PermissionDescriptorPtr and vice versa, the mapping for all content setting permission types is unique and can rely on these mapping utility functions. Permissions that want to make use of permission options in the future, will create the correct PermissionRequestDescriptorPtr instead of relying on the current mapping functions. > > > > Design doc: go/multi-state-permissions-dd > > > > Bug: 394547183, 393053278 > > Change-Id: I620e936a8dd433bfb23e822414126aed94e1995b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6438921 > > Reviewed-by: David Song <[email protected]> > > Commit-Queue: Florian Jacky <[email protected]> > > Reviewed-by: Colin Blundell <[email protected]> > > Reviewed-by: Dmitry Gozman <[email protected]> > > Reviewed-by: Nate Fischer <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1446687} > > Bug: 394547183, 393053278 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: I8bea71bb2ac283c37ea8154e3155c2bb8cf3738f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6454573 > Bot-Commit: Rubber Stamper <[email protected]> > Owners-Override: Victor Tan <[email protected]> > Commit-Queue: Victor Tan <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1446703} Bug: 394547183, 393053278 Change-Id: I52ea81711a8f4125b3d4c2ae531030518cac5472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6455975 Reviewed-by: Peter Beverloo <[email protected]> Reviewed-by: David Song <[email protected]> Reviewed-by: Antonio Rivera <[email protected]> Commit-Queue: Florian Jacky <[email protected]> Reviewed-by: Dmitry Gozman <[email protected]> Reviewed-by: Nate Fischer <[email protected]> Reviewed-by: Victor Tan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1447707}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.