commit | be55153df12fd44a855f9db49f4656e624db3010 | [log] [tgz] |
---|---|---|
author | Takashi Toyoshima <[email protected]> | Fri May 02 18:13:52 2025 |
committer | Chromium LUCI CQ <[email protected]> | Fri May 02 18:13:52 2025 |
tree | 1f07b12d30a87624429a9826062f66532c02b0bb | |
parent | 40708b5c75df2377b28328e83e00a45da4e85832 [diff] |
Reland "NavigationThrottleRunner2: content::NavigationThrottleRegistry" This is a reland of commit 06e076907244efc5fae5abe219b326238889071d The original change below didn't handle a chromecast specific subclass, and it caused a build failure on chromecast bot. Original change's description: > NavigationThrottleRunner2: content::NavigationThrottleRegistry > > This CL introduces a NavigationThrottleRegistry. > CreateThrottlesForNavigation() is changed to use this interface to > register a NavigationThrottle for a new navigation. > > We still handle the returned throttles vector to keep the legacy > interface available. But, once all the existing NavigationThrottle are > migrated to use the NavigationThrottleRegistry, we will remove the > legacy way, and the signature will be changed to return void. > > With this interface, we can implement several optimization step by step > without changing the existing API signature further more. For instance, > we can provide following features via the new registry interface; > - fast access paths to check navigation attributes > - per-event registration to optimize event loops > > Eventually, I will introduce a new NavigationThrottleRunner class. As we > want to share some common implementation among the original runner and > the new runner during the experiment, I will move the common logic to > this registry class and both runners will own it to share the > implementation. > > Essential changes are in the NavigationThrottleRunner, and > //content/public. Others are call side mechanical changes. > > Bug: 412524375 > Change-Id: Ifda11e0f5cf446135c9ab34df025573346c7639c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6478853 > Reviewed-by: Nate Fischer <[email protected]> > Auto-Submit: Takashi Toyoshima <[email protected]> > Commit-Queue: Takashi Toyoshima <[email protected]> > Reviewed-by: Alex Moshchuk <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1454542} Bug: 412524375 Change-Id: Ia2214df9a7b7bc2fc3cdde9d3570b90f52195ffd Cq-Include-Trybots: luci.chromium.try:android-cast-arm64-dbg Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6506662 Reviewed-by: David Dorwin <[email protected]> Reviewed-by: Nate Fischer <[email protected]> Reviewed-by: Alex Moshchuk <[email protected]> Reviewed-by: Devlin Cronin <[email protected]> Reviewed-by: Andrey Kosyakov <[email protected]> Reviewed-by: Simeon Anfinrud <[email protected]> Commit-Queue: Simeon Anfinrud <[email protected]> Auto-Submit: Takashi Toyoshima <[email protected]> Cr-Commit-Position: refs/heads/main@{#1455091}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.