commit | e116ae4b94a5c9344be3c6ef021ed3e22355811f | [log] [tgz] |
---|---|---|
author | Florian Jacky <[email protected]> | Mon Apr 14 19:04:21 2025 |
committer | Chromium LUCI CQ <[email protected]> | Mon Apr 14 19:04:21 2025 |
tree | 5e6fd44683f179279e33bd1574fc34f434f7e973 | |
parent | 0263f1d8ed1911d2be4fcac1fbb8a4a039ff6e3b [diff] |
[PermissionOptions] Use PermissionDescriptorPtr in PermissionControllerDelegate This is part of a larger change to support permission options. Permissions with options can no longer be represented by a simple PermissionType enum value, hence the permission infrastructure will start relying on PermissionDescriptorPtrs instead of PermissionTypes. To reduce the complexity of this CL, it limits the scope of the interface changes to PermissionControllerDelegate, its children and their usages, and uses utility mapping functions to map from PermissionType to PermissionRequestDescriptionPtr, i.e. it does not yet modify the infrastructure itself yet to fully rely on PermissionRequestDescriptorPtr. Since all ContentSetting permission types currently map to exactly one PermissionDescriptorPtr and vice versa, the mapping for all content setting permission types is unique and can rely on these mapping utility functions. Permissions that want to make use of permission options in the future, will create the correct PermissionRequestDescriptorPtr instead of relying on the current mapping functions. Design doc: go/multi-state-permissions-dd Bug: 394547183, 393053278 Change-Id: I620e936a8dd433bfb23e822414126aed94e1995b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6438921 Reviewed-by: David Song <[email protected]> Commit-Queue: Florian Jacky <[email protected]> Reviewed-by: Colin Blundell <[email protected]> Reviewed-by: Dmitry Gozman <[email protected]> Reviewed-by: Nate Fischer <[email protected]> Cr-Commit-Position: refs/heads/main@{#1446687}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.