Skip to content

CAM: Post Process only selected Operations #22764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tarman3
Copy link
Contributor

@tarman3 tarman3 commented Jul 26, 2025

https://forum.freecad.org/viewtopic.php?t=98611

If you need to export only one or few (but not all) Operations you should disable all other Operations
There can be many operations and switching some of them (e.g. 3DSurface, Waterline) can takes a lot of time

This PR added possibility to Post Process only selected Operations from Job

After this changes

  • If select one or several Operations, only selected operations will be export
  • If you select Job or any other object inside Job, all operations will be export

@github-actions github-actions bot added the Mod: CAM Related to the CAM/Path Workbench label Jul 26, 2025
@tarman3 tarman3 force-pushed the postprocess branch 4 times, most recently from 0e85780 to 9920f18 Compare July 27, 2025 18:11
@tarman3
Copy link
Contributor Author

tarman3 commented Jul 27, 2025

@LarryWoestman
I will be grateful if you review this PR
Thank you

@LarryWoestman
Copy link
Contributor

LarryWoestman commented Jul 28, 2025

It seems reasonable to me.

Is there any way to test this other than manually doing things with the GUI?

Also, I can see some situations where someone can end up breaking bits or other things because they have left out some operations in the job and one or more of the remaining operations depends on some material being removed that isn't being removed any more. This isn't any worse than when someone fails to include an operation when defining the job.

Copy link
Contributor

@LarryWoestman LarryWoestman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me.

@tarman3
Copy link
Contributor Author

tarman3 commented Jul 28, 2025

Also, I can see some situations where someone can end up breaking bits or other things because they have left out some operations in the job and one or more of the remaining operations depends on some material being removed that isn't being removed any more. This isn't any worse than when someone fails to include an operation when defining the job.

The main goal for me is to get more control and capabilities

I will not introduce restrictions in order to protect the user from stupid acts
User security only in his hands and head

If you give an idiot a hammer, you cannot hope that he will not break his fingers
If it breaks, these are his problems
And this does not mean that others also cannot use the hammer

This looks reasonable to me.

Thank You
I was not sure in my changes
Function super() is that i am understand not well
Also I searching the way to add argument operations as not mandatory, to not touch all tests and post scripts files

@LarryWoestman
Copy link
Contributor

Python does have the concept of "optional" arguments. I have used that a few times in the refactored code base. I have no problem with adding the "operation" argument where you have added it.

@tarman3
Copy link
Contributor Author

tarman3 commented Jul 28, 2025

Hope I found a compromise between safety and capabilities

Screenshot_20250728_202202_lossy

Screenshot_20250728_202149

@LarryWoestman
Copy link
Contributor

That change should help make it obvious what is being exported.

@tarman3
Copy link
Contributor Author

tarman3 commented Jul 29, 2025

Also I can add some warning message to this dialog
Something like that
Also, I can see some situations where someone can end up breaking bits or other things because they have left out some operations in the job and one or more of the remaining operations depends on some material being removed that isn't being removed any more. This isn't any worse than when someone fails to include an operation when defining the job.

My English is terrible
Maybe you can write some good warning text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: CAM Related to the CAM/Path Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants