Skip to content

Plug leaky sink in logging systests. #5247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2018
Merged

Plug leaky sink in logging systests. #5247

merged 1 commit into from
Apr 27, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Apr 26, 2018 •
edited by dpebot
Loading

Fixes #5242.

@tseaver tseaver added testing api: logging Issues related to the Cloud Logging API. flaky labels Apr 26, 2018
@tseaver tseaver requested a review from theacodes April 26, 2018 21:59
@tseaver tseaver requested a review from lukesneeringer as a code owner April 26, 2018 21:59
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 26, 2018
theacodes
theacodes approved these changes Apr 26, 2018
View reviewed changes
Copy link
Contributor

@theacodes theacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sink

@tseaver
Copy link
Contributor Author

tseaver commented Apr 26, 2018

@dpebot please merge on green.

@dpebot
Copy link
Contributor

dpebot commented Apr 26, 2018

Okay! I'll merge when all statuses are green and all reviewers approve.

@dpebot dpebot added the automerge Merge the pull request once unit tests and other checks pass. label Apr 26, 2018
@dpebot dpebot self-assigned this Apr 26, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Apr 27, 2018

Unrelated pubsub unittest hang (#5252).

@tseaver tseaver merged commit 05c595f into master Apr 27, 2018
@tseaver tseaver deleted the 5242-logging-fix_systest_sink_leak branch April 27, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

1 more reviewer

@theacodes theacodes theacodes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dpebot dpebot

Labels

api: logging Issues related to the Cloud Logging API. automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement. flaky testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver @dpebot @theacodes @googlebot