Add type-checking via pytype to api_core. #6116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With these changes, pytype can now be run on api_core with the following steps in a Python 3.5 or 3.6 virtualenv: $ git clone [email protected]:GoogleCloudPlatform/google-cloud-python.git $ pip install googleapis-common-protos protobuf google-auth requests \ setuptools six pytz futures grpcio grpcio-gcp $ pip install pytype $ cd google-cloud-python/api_core/ $ pytype -V3.5 # or 3.6
googlebot
added
the
cla: yes
theacodes
added
the
kokoro:force-run
kokoro-team
removed
kokoro:force-run
theacodes
reviewed
Sep 27, 2018
theacodes
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
Thank you, @rchen152! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type-checks all of api_core outside of tests with pytype.
pytype -V{major.minor}.pytype -V3.5andpytype -V3.6under nox.Manually tested by pip-installing
pytypeandnox-automationin a Python 3.6 virtualenv.@theacodes cc-ing you on this PR as you requested