Skip to content

Pin minimum protobuf dependency to 3.4.0. #6132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2018
Merged

Pin minimum protobuf dependency to 3.4.0. #6132

merged 1 commit into from
Sep 28, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 28, 2018

See: #6128.

We will need to make an api_core-1.5.0 release (or maybe 1.4.1) as soon as this is merged.

@tseaver tseaver added api: compute Issues related to the Compute Engine API. packaging labels Sep 28, 2018
@tseaver tseaver requested a review from theacodes September 28, 2018 16:48
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 28, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Sep 28, 2018

@theacodes I verified manually that pubsub-3.4.0 was the lowest version which made the pubsub unit tests pass. We could go ahead and pin it to the current version (3.6.1) if you think that is better.

@tseaver tseaver merged commit ab83141 into googleapis:master Sep 28, 2018
@tseaver tseaver deleted the 6128-api_core-minimum_protobuf_dep_3.4.0 branch September 28, 2018 16:58
@tseaver tseaver mentioned this pull request Sep 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@theacodes theacodes theacodes approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: compute Issues related to the Compute Engine API. cla: yes This human has signed the Contributor License Agreement. packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @theacodes @googlebot