8303475: potential null pointer dereference in filemap.cpp

calvinccheung · calvinccheung · commit e1196584d5c6 · 2023-04-28T15:45:44.000Z
Reviewed-by: dholmes
diff --git a/src/hotspot/share/cds/filemap.cpp b/src/hotspot/share/cds/filemap.cpp
@@ -361,6 +361,7 @@ void SharedClassPathEntry::set_name(const char* name, TRAPS) {
 }
 
 void SharedClassPathEntry::copy_from(SharedClassPathEntry* ent, ClassLoaderData* loader_data, TRAPS) {
+  assert(ent != NULL, "sanity");
   _type = ent->_type;
   _is_module_path = ent->_is_module_path;
   _timestamp = ent->_timestamp;

Original file line number	Diff line number	Diff line change
`@@ -361,6 +361,7 @@ void SharedClassPathEntry::set_name(const char* name, TRAPS) {`
`361`	`361`	`}`
`362`	`362`
`363`	`363`	`void SharedClassPathEntry::copy_from(SharedClassPathEntry* ent, ClassLoaderData* loader_data, TRAPS) {`
	`364`	`+ assert(ent != NULL, "sanity");`
`364`	`365`	`_type = ent->_type;`
`365`	`366`	`_is_module_path = ent->_is_module_path;`
`366`	`367`	`_timestamp = ent->_timestamp;`