addressing lint issues

Ahmed3lmallah · Ahmed3lmallah · commit c89b41fdc6d9 · 2024-11-20T21:41:54.000Z
diff --git a/src/deny.ts b/src/deny.ts
@@ -9,15 +9,13 @@ export async function getDeniedChanges(
 ): Promise<Change[]> {
   const changesDenied: Change[] = []
 
-  let hasDeniedPackage = false
   for (const change of changes) {
     for (const denied of deniedPackages) {
       if (
         (!denied.version || change.version === denied.version) &&
         change.name === denied.name
       ) {
         changesDenied.push(change)
-        hasDeniedPackage = true
       }
     }
 
@@ -30,7 +28,6 @@ export async function getDeniedChanges(
       }
       if (namespace && namespace === denied.namespace) {
         changesDenied.push(change)
-        hasDeniedPackage = true
       }
     }
   }
diff --git a/src/main.ts b/src/main.ts
@@ -210,7 +210,7 @@ async function run(): Promise<void> {
   }
 }
 
-function printVulnerabilitiesBlock(
+async function printVulnerabilitiesBlock(
   addedChanges: Changes,
   minSeverity: Severity,
   warnOnly: boolean
@@ -253,7 +253,7 @@ function printChangeVulnerabilities(change: Change): boolean {
   return change.vulnerabilities.length > 0
 }
 
-function printLicensesBlock(
+async function printLicensesBlock(
   invalidLicenseChanges: Record<string, Changes>,
   warnOnly: boolean
 ): Promise<boolean> {
@@ -383,10 +383,10 @@ function printScannedDependencies(changes: Changes): void {
   })
 }
 
-function printDeniedDependencies(
+async function printDeniedDependencies(
   changes: Changes,
   config: ConfigurationOptions
-): Promise<boolean> {  
+): Promise<boolean> {
   return core.group('Denied', async () => {
     let issueFound = false
 

Original file line number	Diff line number	Diff line change
`@@ -9,15 +9,13 @@ export async function getDeniedChanges(`
`9`	`9`	`): Promise<Change[]> {`
`10`	`10`	`const changesDenied: Change[] = []`
`11`	`11`
`12`		`- let hasDeniedPackage = false`
`13`	`12`	`for (const change of changes) {`
`14`	`13`	`for (const denied of deniedPackages) {`
`15`	`14`	`if (`
`16`	`15`	`(!denied.version \|\| change.version === denied.version) &&`
`17`	`16`	`change.name === denied.name`
`18`	`17`	`) {`
`19`	`18`	`changesDenied.push(change)`
`20`		`- hasDeniedPackage = true`
`21`	`19`	`}`
`22`	`20`	`}`
`23`	`21`
`@@ -30,7 +28,6 @@ export async function getDeniedChanges(`
`30`	`28`	`}`
`31`	`29`	`if (namespace && namespace === denied.namespace) {`
`32`	`30`	`changesDenied.push(change)`
`33`		`- hasDeniedPackage = true`
`34`	`31`	`}`
`35`	`32`	`}`
`36`	`33`	`}`