Revert cluster link identity type#16259
Merged
tomponline merged 6 commits intocanonical:mainfrom Aug 20, 2025
Merged
Conversation
…ate identity types" This reverts commit d051bf5. Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> License: Apache-2.0
This reverts commit 8b5c7c4. Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> License: Apache-2.0
…ivatable identities" This reverts commit b255459. Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> License: Apache-2.0
…mentations" This reverts commit e5228eb. Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> License: Apache-2.0
kadinsayani
force-pushed
the
revert/cluster-link-identity
branch
from
991e14e to
ec9d3a0
Compare
kadinsayani
requested review from
Copilot and
tomponline
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the cluster link identity type functionality by removing support for cluster link certificate authentication types that were previously added to LXD. The changes remove two identity types: "Cluster link certificate" and "Cluster link certificate (pending)" along with their associated code.
Key changes:
- Remove cluster link identity type constants and implementations
- Simplify token handling to only process client certificate pending identities
- Update authentication to exclude cluster link certificate types
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| shared/api/auth.go | Removes cluster link identity type constants |
| lxd/tokens.go | Simplifies expired pending identity retrieval to only handle client certificates |
| lxd/identity/type_interface.go | Removes cluster link identity type constants and removes types from registry |
| lxd/identity/certificate_cluster_link.go | Completely removes cluster link identity type implementations |
| lxd/db/cluster/identities.go | Removes cluster link activation logic and updates documentation |
| lxd/daemon.go | Removes cluster link certificate type from authentication candidates |
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
…usterLinkPending` API types" This reverts commit 06f4975. Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> License: Apache-2.0
kadinsayani
force-pushed
the
revert/cluster-link-identity
branch
from
ec9d3a0 to
1bdea8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.