Replies: 1 comment 11 replies
-
Use a variable to remember the old directory. local old_dir
local function detect_dir_change()
local new_dir = os.getcwd()
if new_dir ~= old_dir then
print("DIR CHANGED:", old_dir, "->", new_dir)
old_dir = new_dir
end
end
clink.onbeginedit(detect_dir_change)
It sounds like you want Lua callbacks in the middle of the CMD batch language parser and interpreter. It sounds like you want CMD to execute That isn't possible because the CMD batch language parser and interpreter is a closed system that Clink cannot penetrate. The order is this:
Clink cannot "hook" into the internals of the batch scripting language. And even if it could, it should not: because if it did then that would create compatibility problems, because Clink would be able to change how batch scripts work and execute. Clink is currently 100% compatible with existing batch scripts, but if it could allow Lua to run during batch scripts (which it can't -- there are no hooks from CMD to facilitate that) then Clink would no longer be compatible with existing batch scripts. That would be a major problem. If you're trying to get CMD to delay expansion of environment variables, then that's a CMD thing and has nothing to do with Clink. You can learn more about delayed expansion by referring to CMD documentation, or by using internet searches (or by asking AI, but be prepared for the answers to be misleading and only half accurate...). Here is an article that's a great tutorial on using delayed expansion: How to Enable and Use Delayed Expansion in Batch Script. |
Beta Was this translation helpful? Give feedback.
-
I agree with you on Reentrancy and Targeting. I can't say that about Side effects because it doesn't need to work everywhere. It just needs to work where Clink lives. But yeah, I'm talking about a specific use-case that neither expects to do
It works as expected in my case. > sample.bat
FOO=updated value |
Beta Was this translation helpful? Give feedback.
-
"Side effects" is already assuming that we're only talking about Clink. "Side effects" refers to the fact that executing Lua code inside
Exactly: you're looking only at a specific case you want to use. It's understandable to accidentally hyper focus on that. But adding the ability opens the door for many other cases that have the ability to break things. There's no way to guarantee that other people won't encounter the cases you didn't care about.
Not safely. You're free to use a custom version of Clink with whatever changes you want to make, but I can't support it. If you distribute it, please change the name and make it very clear to users that they need to contact you for support, not me. |
Beta Was this translation helpful? Give feedback.
-
I applied your patch and rebuilt.
|
Beta Was this translation helpful? Give feedback.
-
|
Update: My mistake: I had a typo that prevented the onchangedirectory event callback from getting registered. Once the typo was fixed then it reports I attached a debugger and found that the reason it reports So, my predicted example was inaccurate. That doesn't change anything about the bigger picture of what's going on and why invoking the Lua engine inside of |
Beta Was this translation helpful? Give feedback.
-
|
Understandable. I don't wish to use custom clink just so that it could have I'll just add a note to either explicitly call hook-env after every cd or add a setting to shim using cd.cmd. Thank you for the detailed explanation. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Overview
Can there be a hook that can respond to directory changes (i.e. probably hooking SetCurrentDirectoryW)?
Motivation
Current implementations require use of either
clink.onbegineditorclink.onendeditto check if directory changes. These face problems like:cd .. && echo %MY_CWD%) would print the previous value of MY_CWD and then updating on next prompt start/end. I expect the flow to be:cd -> callbacks -> echoBeta Was this translation helpful? Give feedback.
All reactions