Mark all core run functions with noexcept
#2251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cores do not use, handle, or throw exceptions. There were only a couple uses of the "new" operator, which can throw if it fails to allocate memory. So this commit move those to the no-throwing variant. The core themselves only use return codes to manage signal handling and control flow (both good and bad). If things go off the rails, they quit immediately with E_Exit.
kcgen
changed the title
noexcept
kcgen
added
the
plumbing
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cores do not use, handle, or throw exceptions.
There were only a couple uses of the
newoperator inside the entiresrc/cputree (newitself can throw if it fails to allocate, so this commit moves those to their no-throwing variant).The cores themselves only use return codes for signal handling and control flow (both good and bad). If things go off the rails, they quit immediately with
E_Exit().This simply labels them as such (programmatically) as it's how they were designed.