Skip to content

Fix pause_when_inactive mouse behavior for macOS and Linux #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 2, 2023

Conversation

FeralChild64
Copy link
Collaborator

Fixes #2255

First commit is the actual fix, second is a minor cleanup (function/variable naming harmonization).

@FeralChild64 FeralChild64 added bug Something isn't working backport Important fixes that should be backported labels Jan 31, 2023
@FeralChild64 FeralChild64 self-assigned this Jan 31, 2023
@kcgen
Copy link
Member

kcgen commented Jan 31, 2023

Looks great @FeralChild64 , and I really like the naming harmonization - now very can directly mentally match the concepts between source files 👍

Added a commit to main to print the log on setup failure, when you have a chance to rebase.

@kcgen
Copy link
Member

kcgen commented Jan 31, 2023

The log revealed the issue:

2023-01-31T19:53:34.1755880Z Initialized empty Git repository in /home/runner/work/dosbox-staging/dosbox-staging/subprojects/gvdb/.git/
2023-01-31T19:53:34.9622053Z fatal: unable to access 'https://gitlab.gnome.org/GNOME/gvdb.git/': The requested URL returned error: 503

Literally every time we've had dependency fetch failures, it's because Gnome's gitlab server is failing and the guy who maintains it needs to reboot it.

(Reflecting on using GitHub: It's sure nice having this stress off our shoulders, knowing that paid staff are taking care of our infrastructure!)

@FeralChild64
Copy link
Collaborator Author

@kcgen There is still some dependency error:

WARNING: Variable '-libpcre2_8' in the subproject 'subprojects/pcre2-10.40' is not found
Dependency libpcre2-8 from subproject subprojects/pcre2-10.40 found: NO
Dependency libpcre2-8 from subproject subprojects/pcre2-10.40 found: YES 10.40
Using subprojects/glib-2.74.1/subprojects/gvdb.wrap
Message: You can disable this dependency with: -Duse_slirp=false

subprojects/glib-2.74.1/meson.build:2089:0: ERROR: Git command failed: ['/usr/bin/git', 'fetch', '--depth', '1', 'origin', '0854af0fdb6d527a8d1999835ac2c5059976c210']
Error: Process completed with exit code 1.

@kcgen
Copy link
Member

kcgen commented Jan 31, 2023

@kcgen There is still some dependency error:

WARNING: Variable '-libpcre2_8' in the subproject 'subprojects/pcre2-10.40' is not found
Dependency libpcre2-8 from subproject subprojects/pcre2-10.40 found: NO
Dependency libpcre2-8 from subproject subprojects/pcre2-10.40 found: YES 10.40
Using subprojects/glib-2.74.1/subprojects/gvdb.wrap
Message: You can disable this dependency with: -Duse_slirp=false

subprojects/glib-2.74.1/meson.build:2089:0: ERROR: Git command failed: ['/usr/bin/git', 'fetch', '--depth', '1', 'origin', '0854af0fdb6d527a8d1999835ac2c5059976c210']
Error: Process completed with exit code 1.

Yes, it's stemming from gvdb.

In the failing Linux release workflow, click the gear icon and select 'view raw log', which is the full stdout and stderr.

Search it for 'gvdb', and you'll see git getting a 503 failure fetching it from gitlab's repo.

Then if you go back to the last successful main Linux release workflow, gvdb is fetched and compiled without issue.

Slirp depends on glib which depends on gvdb. For the Linux release, we build all of these statistically and optimized from sources (compared to non-release workflows where shared libs are used from the Linux distro).

I'll go poke around in gnome's gitlab and see if I can learn more.

@kcgen
Copy link
Member

kcgen commented Jan 31, 2023

https://gitlab.gnome.org/GNOME/gvdb

I can't even connect to the web front 😢

Edit: their whole site is kaputnik.

https://gitlab.gnome.org/

Screenshot_20230131-130019_Firefox

@FeralChild64 FeralChild64 marked this pull request as draft January 31, 2023 21:04
@FeralChild64
Copy link
Collaborator Author

FeralChild64 commented Jan 31, 2023

@kcgen, @johnnovak: I have found a regression: with seamless mouse enabled, the internal mouse cursor does not move any more if DOSBox window loses focus. This is not a desirable behavior, I need to fix it.

PR converted to draft for now.

@kcgen
Copy link
Member

kcgen commented Feb 1, 2023

Gnome's server is back online.

Added a ticket here: https://gitlab.gnome.org/GNOME/glib/-/issues/2906

@FeralChild64 FeralChild64 marked this pull request as ready for review February 2, 2023 15:10
@FeralChild64
Copy link
Collaborator Author

@kcgen, @johnnovak: Regression fixed - ready for review again.

Copy link
Member

@kcgen kcgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good @FeralChild64!

(I've pushed an update for the unrelated pylint warning coming from the code analysis workflow.)

@kcgen kcgen merged commit 74aa780 into main Feb 2, 2023
@delete-merged-branch delete-merged-branch bot deleted the fc/mouse-focus-fix-1 branch February 2, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Important fixes that should be backported bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Mouse is broken with pause_when_inactive enabled in the config file on macOS
2 participants