-
-
Notifications
You must be signed in to change notification settings - Fork 172
Fix pause_when_inactive
mouse behavior for macOS and Linux
#2262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks great @FeralChild64 , and I really like the naming harmonization - now very can directly mentally match the concepts between source files 👍 Added a commit to |
The log revealed the issue:
Literally every time we've had dependency fetch failures, it's because Gnome's gitlab server is failing and the guy who maintains it needs to reboot it. (Reflecting on using GitHub: It's sure nice having this stress off our shoulders, knowing that paid staff are taking care of our infrastructure!) |
28da5c7
to
9f97ae9
Compare
@kcgen There is still some dependency error:
|
Yes, it's stemming from gvdb. In the failing Linux release workflow, click the gear icon and select 'view raw log', which is the full stdout and stderr. Search it for 'gvdb', and you'll see git getting a 503 failure fetching it from gitlab's repo. Then if you go back to the last successful Slirp depends on glib which depends on gvdb. For the Linux release, we build all of these statistically and optimized from sources (compared to non-release workflows where shared libs are used from the Linux distro). I'll go poke around in gnome's gitlab and see if I can learn more. |
https://gitlab.gnome.org/GNOME/gvdb I can't even connect to the web front 😢 Edit: their whole site is kaputnik. |
@kcgen, @johnnovak: I have found a regression: with seamless mouse enabled, the internal mouse cursor does not move any more if DOSBox window loses focus. This is not a desirable behavior, I need to fix it. PR converted to draft for now. |
Gnome's server is back online. Added a ticket here: https://gitlab.gnome.org/GNOME/glib/-/issues/2906 |
7d5eb6b
to
8af2e96
Compare
@kcgen, @johnnovak: Regression fixed - ready for review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good @FeralChild64!
(I've pushed an update for the unrelated pylint warning coming from the code analysis workflow.)
Fixes #2255
First commit is the actual fix, second is a minor cleanup (function/variable naming harmonization).