-
-
Notifications
You must be signed in to change notification settings - Fork 172
Add translation batch file for Windows #2303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The batch file looks good @Kappa971 👍 For the binaries in If we have documentation for translators, these tools could be part of the per-requisites (similar to how those wanting to compile have to download Meson, clang, gcc, etc). Another suggestion would be to add The batch file could even type it: if NOT EXIST tools\uconv.exe type tools\readme.txt
if NOT EXIST tools\dos2unix.exe type tools\readme.txt (or something like that) We would also then want git to ignore any new files found inside |
It would be better to be able to download the necessary tools (in Windows 10 and 11 there is |
I know what you mean, @Kappa971 - it would be nice to offer this, but it gets even trickier: you have to figure out what architecture (ARM vs x86-32bit vs x86-64-bit) they're running too.. and yeah, then also keep these scripts updated to fetch the latest version. Fortunately for anyone wanting to put in the help to translate (and that's not a small amount of work!) downloading a couple zip files and unpacking them is a tiny step - and it's just a one-time step. |
|
I like the current approach with the readme; interested translators can download the tools and unzip them without much trouble. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @Kappa971.
I will squash the three commits into one, which would eliminate the binaries from the commit history.
I was forgetting... translators need to update the German, French and Spanish translations with the new color tags to avoid the dos2unix error. |
We talked about it here: #2302
Includes
uconv
, taken from the ICU v72.1 package, anddos2unix
v7.4.4 (32-bit versions).