Disable FluidSynth's own unit tests under MSYS2 CI #2357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcgen
added
Windows
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every week, GitHub applies stable updates and security patches to their VMs and rolls them over. This week's rollover introduced some change impacting how MSYS2's Clang LLD linker imports DLL symbols - causing all of FluidSynth's unit tests to start failing (only under MSYS2 Clang):
Prior to the VM rollover on the 19th, all branches and
mainwere fine:FluidSynth's unit tests compiled and ran on the prior
maincommit: https://github.com/dosbox-staging/dosbox-staging/actions/runs/4440895580So this PR just disables these unit tests under MSY2 CI for now.
Let's hope the problem is causing wide-spread issues and GitHub (or MSYS2) are on top of this issue and it's fixed in the next rollover (and we can try reverting this commit in the commits weeks).