-
-
Notifications
You must be signed in to change notification settings - Fork 172
Rework AUTOEXEC.BAT support, make it UTF-8 aware #2425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
02f3c33
to
0ddec11
Compare
6bc6364
to
24706d1
Compare
@FeralChild64 , thanks for the sample testing code. Working good here, and with other attempts to exercise it. |
d24f57b
to
17c36ea
Compare
Back to draft, after handling most of the review remarks I need to re-check and cleanup the implementation. |
353ce31
to
f9a7411
Compare
5be7260
to
9d137c5
Compare
9d137c5
to
bdaa9ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another big overhaul of the previously convoluted shell handling; thanks @FeralChild64 ! All comments addressed - let's merge.
AUTOEXEC.BAT
support to a separate file, reworked the code to use modern C++ featuresZ:\AUTOEXEC.BAT
should be more aesthetic now[autoexec]
section is now UTF-8 awareNOTE: This PR will need a small (trivial) adaptation after #2422 is merged, due to renamed
UTF8_GetCodePage
andUTF8_RenderForDos
. When both are merged, the autoexec-related problems mentioned on Discord by @dreamer should be resolved.A quick&dirty test - open
dosbox-staging.conf
in your favorite editor, add the following lines to the[autoexec]
section, and save it as UTF-8 file (this is crucial!):Afterwards:
KEYB
commands above) that it printed out the text according to the code page set at given moment.type Z:\AUTOEXEC.BAT
commands - check that DOSBox always adapts the content of theAUTOEXEC.BAT
to the currently active code page.