@kcgen maybe we should add _GLIBCXX_DEBUG to on of our builds to see if we can trigger this assert in CI (maybe clang static analysis build will manage to trigger this?).

@LowLevelMahn update the commit message according to rule 5, please.

@LowLevelMahn update the commit message according to rule 5, please.

so "replaces" becomes "Replace"?

@kcgen maybe we should add _GLIBCXX_DEBUG to on of our builds to see if we can trigger this assert in CI (maybe clang static analysis build will manage to trigger this?).

does the CI also start dosbox (its only triggered at runtime)?

@kcgen maybe we should add _GLIBCXX_DEBUG to on of our builds to see if we can trigger this assert in CI (maybe clang static analysis build will manage to trigger this?).

Yes - seems like we should have this in our debug builds? We should catch these straight away in a debug (and assert-enabled) builds.

there is also _GLIBCXX_SANITIZE_VECTOR (see: https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_macros.html)

When defined, std::vector operations will be annotated so that AddressSanitizer can detect invalid accesses to the unused capacity of a std::vector.

and the libc++ from the LLVM project also got sanitizing for std::string, std::vector, std::deque and some others

but i didn't tested them

Looks good, thanks @LowLevelMahn !