Skip to content

Implement DOS mouse driver function 0x32 #2508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2023
Merged

Implement DOS mouse driver function 0x32 #2508

merged 1 commit into from
May 21, 2023

Conversation

FeralChild64
Copy link
Collaborator

  • implement one more informational function of the DOS mouse driver - might help applications to determine which functions our driver implements
  • manually clean-up some indentation

@FeralChild64 FeralChild64 added the enhancement New feature or enhancement of existing features label May 21, 2023
@FeralChild64 FeralChild64 requested review from johnnovak and kcgen May 21, 2023 09:00
@FeralChild64 FeralChild64 self-assigned this May 21, 2023
johnnovak
johnnovak approved these changes May 21, 2023
View reviewed changes
Copy link
Member

@johnnovak johnnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, although I have no idea what this is doing 😄 Did you test it with something that uses this?

kcgen
kcgen approved these changes May 21, 2023
View reviewed changes
Copy link
Member

@kcgen kcgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @FeralChild64 - and nice logging refinements.

@kcgen kcgen merged commit 9f507e1 into main May 21, 2023
@FeralChild64
Copy link
Collaborator Author

Looks okay, although I have no idea what this is doing smile Did you test it with something that uses this?

It returns a bitfield telling which functions the mouse driver supports. Unfortunately, I haven't found anything that uses it - but the implementation itself is rather trivial.
In fact, some software SHOULD call this function, but it doesn't - for example, MSD.EXE calls function 0x34 to get the MOUSE.INI file path information, not checking first whether the driver supports function 0x34 or not :/

@johnnovak
Copy link
Member

Looks okay, although I have no idea what this is doing smile Did you test it with something that uses this?

It returns a bitfield telling which functions the mouse driver supports. Unfortunately, I haven't found anything that uses it - but the implementation itself is rather trivial. In fact, some software SHOULD call this function, but it doesn't - for example, MSD.EXE calls function 0x34 to get the MOUSE.INI file path information, not checking first whether the driver supports function 0x34 or not :/

Thanks for the explanation @FeralChild64.

@FeralChild64 FeralChild64 deleted the fc/mouse-function-0x32-1 branch May 25, 2023 06:57
@Grounded0 Grounded0 mentioned this pull request Nov 17, 2023
Closed
4 tasks
@johnnovak johnnovak added the input handling Issues related to handling any input (keyboard, mouse, joystick & game controllers) label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnovak johnnovak johnnovak approved these changes

@kcgen kcgen kcgen approved these changes

Assignees

@FeralChild64 FeralChild64

Labels
enhancement New feature or enhancement of existing features input handling Issues related to handling any input (keyboard, mouse, joystick & game controllers)
Projects
No open projects
0.81 Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FeralChild64 @johnnovak @kcgen