Skip to content

Fix mounting directory with space in its name, passed as an argument #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2023
Merged

Fix mounting directory with space in its name, passed as an argument #2626

merged 1 commit into from
Jun 21, 2023

Conversation

FeralChild64
Copy link
Collaborator

Fix the following problem, reported by user Jow on Discord:

  • prepare directory with space in it's name
  • pass it as an argument to DOSBox executable (dosbox "/path/to/directory with space/" on Linux)
  • DOSBox fails to mount the directory as drive C:

Reason: lack of quotation marks in the MOUNT command in generated Z:\AUTOEXEC.BAT file.

@FeralChild64 FeralChild64 added bug Something isn't working regression We broke something 😊 labels Jun 21, 2023
@FeralChild64 FeralChild64 requested review from johnnovak and kcgen June 21, 2023 14:56
@FeralChild64 FeralChild64 self-assigned this Jun 21, 2023
kcgen
kcgen approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@kcgen kcgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice fix!

@kcgen kcgen merged commit 6b108b4 into main Jun 21, 2023
@kcgen kcgen deleted the fc/autoexec-fix-2 branch June 21, 2023 16:23
@Grounded0 Grounded0 mentioned this pull request Nov 17, 2023
Closed
4 tasks
@johnnovak johnnovak added the DOS Issues related to DOS integration or DOS commands label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcgen kcgen kcgen approved these changes

@johnnovak johnnovak Awaiting requested review from johnnovak

Assignees

@FeralChild64 FeralChild64

Labels
bug Something isn't working DOS Issues related to DOS integration or DOS commands regression We broke something 😊
Projects
No open projects
0.81 Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FeralChild64 @kcgen @johnnovak