Skip to content

Omit blank lines from command history #2673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2023
Merged

Omit blank lines from command history #2673

merged 2 commits into from
Jul 10, 2023

Conversation

johnnovak
Copy link
Member

@johnnovak johnnovak commented Jul 10, 2023 •
edited
Loading

Should be self-explanatory. Type dir in the current version, then press Enter a couple of times, then execute say mixer. You can't just press up-arrow twice to get back to the dir command in the history; you need to go through every single blank line as well...

That's quite bad; none of the normal shells work like that!

johnnovak added 2 commits July 10, 2023 21:29
@johnnovak
Reformat
2e6308c
@johnnovak
Do no store blank lines in command history
2924cdc 
This is how all good command line shells work.
@johnnovak johnnovak self-assigned this Jul 10, 2023
@johnnovak johnnovak added the enhancement New feature or enhancement of existing features label Jul 10, 2023
weirddan455
weirddan455 approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@weirddan455 weirddan455 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change. I wrote some checks to avoid reading and writing blank lines to the history file but that didn't affect the in memory history for the current session.

@johnnovak johnnovak merged commit 55f0d6c into main Jul 10, 2023
@johnnovak johnnovak deleted the jn/omit-blank-lines-from-command-history branch July 12, 2023 08:18
@Grounded0 Grounded0 mentioned this pull request Nov 17, 2023
Closed
4 tasks
@johnnovak johnnovak added the DOS Issues related to DOS integration or DOS commands label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weirddan455 weirddan455 weirddan455 approved these changes

@FeralChild64 FeralChild64 FeralChild64 approved these changes

Assignees

@johnnovak johnnovak

Labels
DOS Issues related to DOS integration or DOS commands enhancement New feature or enhancement of existing features
Projects
No open projects
0.81 Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnnovak @weirddan455 @FeralChild64