Skip to content

Improve compile commits script #2760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Conversation

johnnovak
Copy link
Member

@johnnovak johnnovak commented Aug 15, 2023

  • Compile commits in forward order, starting from the oldest one
  • Check out the branch itself when done instead of the head commit by hash

☝🏻 Should be pretty straighforward. Creating this script was a great idea @kcgen and it's super handyβ€”I just wished it worked a bit differently... now it does 😎

Feel feel to disagree with any of this; I just find this slightly tweaked mode of operation more useful. Especially checking out the head by commit hash vs the actual branch name at the end trips me up every single time πŸ˜… I would expect the script to restore the "Git state" exactly to where it was started from.

- Compile commits in forward order, starting from the oldest one
- Check out the branch itself when done instead of the head commit by
  hash
@johnnovak johnnovak self-assigned this Aug 15, 2023
@johnnovak johnnovak added the build system Build system related issues label Aug 15, 2023
@johnnovak johnnovak marked this pull request as ready for review August 15, 2023 01:17
Copy link
Member

@kcgen kcgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and nice improvement!

@johnnovak johnnovak merged commit b1bf242 into main Aug 15, 2023
@kcgen kcgen deleted the jn/improve-compile-commits-script branch August 25, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system Build system related issues
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants