Notify all when RWQueue stops #2775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good 👍 |
kcgen
added
the
plumbing
kcgen
approved these changes
Aug 20, 2023
|
In the main thread, call Then inside the threaded processing function, always check the
Hope it helps! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found another bug in RWQueue. We need to notify all threads when the queue stops or we can have a deadlock.
I'm pretty sure I'll need to add a couple more methods to this class as well once I get FFmpeg threading sorted out but that'll go in my big PR alongside the use case. At a minimum, I think I'll need a
Drainmethod and aStartmethod so that I canStopthe queue,Drainall remaining elements from it in a non-blocking manner, and thenStartit back up again.For now though, I'm just pushing these bug fixes in small PRs as I see them since this could cause a stall in existing code.