Skip to content

Suppress ALSA API macros PVS Studio warnings #2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Conversation

FeralChild64
Copy link
Collaborator

The last PR of my PVS Studio crusade - at least for now :)

This time I would like to suppress some warnings, shown on the screenshot below. These are all originating from ALSA headers - the snd_* are macros, which PVS Studio does not like. I believe there is nothing sane we can do about them (we probably don't want to alter ALSA headers after all), other than ignoring these.

PVS

@FeralChild64 FeralChild64 added the CI GitHub Actions / CI related issues label Aug 23, 2023
@FeralChild64 FeralChild64 self-assigned this Aug 23, 2023
@FeralChild64
Copy link
Collaborator Author

Why the MSVC 64-bit build suddenly started exceeding the warning limit? Did the GitHub silently alter the pipeline, or what?

@kcgen
Copy link
Member

kcgen commented Aug 23, 2023

Why the MSVC 64-bit build suddenly started exceeding the warning limit? Did the GitHub silently alter the pipeline, or what?

They did. From VS rev 14.35.xyz to 14.36.abc; looks like a patch update.

Suggest bumping the count to match the new detection quantity, and mention the VS rev change (no one's fault, just better warning detection).

@FeralChild64
Copy link
Collaborator Author

OK. I still don't like such changes being made without clear warning and explicit consent from the project.

@FeralChild64 FeralChild64 merged commit 3275f03 into main Aug 23, 2023
@FeralChild64 FeralChild64 deleted the fc/static-analysis-4 branch August 23, 2023 21:22
@kcgen
Copy link
Member

kcgen commented Aug 23, 2023

It was an excellent crusade; almost the half of Peaveestalia has been conquered 📯 🏴

@johnnovak
Copy link
Member

OK. I still don't like such changes being made without clear warning and explicit consent from the project.

Yeah that's a bit dodgy, isn't it...

@FeralChild64
Copy link
Collaborator Author

@kcgen Actually, this was just 1/3 (when I started we had 265 warnings, we are down to 170 now; but few warnings were fixed in the meantime by others), and mostly just the low-hanging fruits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI GitHub Actions / CI related issues
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants