Video related refactorings #2808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice cleanup - just a few very minor remarks from my side. |
weirddan455
reviewed
Aug 31, 2023
johnnovak
force-pushed
the
jn/video-cleanup-stuff
branch
from
b3e27dd to
e02fd8c
Compare
johnnovak
force-pushed
the
jn/video-cleanup-stuff
branch
from
e02fd8c to
0faa34f
Compare
kcgen
reviewed
Sep 1, 2023
johnnovak
force-pushed
the
jn/video-cleanup-stuff
branch
from
dd76073 to
087fc4f
Compare
kcgen
reviewed
Sep 1, 2023
kcgen
reviewed
Sep 1, 2023
kcgen
reviewed
Sep 1, 2023
kcgen
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
That's a lot of cleanup to get names standardized across all these files! Looks great, @johnnovak.
|
Thanks for the review @kcgen @FeralChild64 @kcgen 👍🏻 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some non-functional refactorings that I want to merge separately (part of some upcoming adaptive CRT shader enhancement I've been working on for EGA modes on VGA; stay tuned).
Less noise in my actual functional PR this way. Plus reviewing multiple refactoring PRs followed by one much smaller functional PR is less taxing psychologically on reviewers 😅
Suggest to review by commit.