Skip to content

Add short prompts for MORE commands for 40 column screen modes #2953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

FeralChild64
Copy link
Collaborator

@FeralChild64 FeralChild64 commented Sep 21, 2023

Description

I would still prefer MORE command not to break on 40 column screen modes, thus I have added short prompts, which do not contain ANY tips/hints for the user; this way they will remain short for every translation imaginable.

I agree that no one uses them on purpose, but sometimes we end up in one when the program malfunctions and terminates - the change is to give a small aid to the user, who might want to do some recovery actions or post-mortem analysis.

Manual testing

I have only tested this by manually changing use_short_prompt condition in the code, to trigger displaying short prompts.

Checklist

I have:

  • followed the project's contributing guidelines and code of conduct.
  • performed a self-review of my code.
  • commented on the particularly hard-to-understand areas of my code.
  • split my work into well-defined, bisectable commits, and I named my commits well.
  • applied the appropriate labels (bug, enhancement, refactoring, documentation, etc.)
  • checked that all my commits can be built.
  • confirmed that my code does not cause performance regressions (e.g., by running the Quake benchmark).
  • added unit tests where applicable to prove the correctness of my code and to avoid future regressions.
  • made corresponding changes to the documentation or the website according to the documentation guidelines.
  • locally verified my website or documentation changes.

@FeralChild64 FeralChild64 added the enhancement New feature or enhancement of existing features label Sep 21, 2023
@FeralChild64 FeralChild64 self-assigned this Sep 21, 2023
@FeralChild64 FeralChild64 marked this pull request as ready for review September 21, 2023 19:17
Copy link
Member

@johnnovak johnnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little addition for those poor people stranded in a 40-column mode @FeralChild64; I agree it doesn't hurt to have this 😄

@FeralChild64 FeralChild64 merged commit 180fc31 into main Sep 22, 2023
@FeralChild64 FeralChild64 deleted the fc/more-40columns-1 branch September 25, 2023 04:54
@johnnovak johnnovak added the DOS Issues related to DOS integration or DOS commands label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOS Issues related to DOS integration or DOS commands enhancement New feature or enhancement of existing features
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants