Skip to content

Sync YM1728B_emu with upstream #3021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Sync YM1728B_emu with upstream #3021

merged 2 commits into from
Oct 17, 2023

Conversation

weirddan455
Copy link
Collaborator

Description

We diverged from upstream in only one place. I just copy + pasted the upstream files and then manually re-applied 29419da (one line commit changing from double to float).

Related issues

#2998

Checklist

Please tick the items as you have addressed them. Don't remove items; leave the ones that are not applicable unchecked.

I have:

  • followed the project's contributing guidelines and code of conduct.
  • performed a self-review of my code.
  • commented on the particularly hard-to-understand areas of my code.
  • split my work into well-defined, bisectable commits, and I named my commits well.
  • applied the appropriate labels (bug, enhancement, refactoring, documentation, etc.)
  • checked that all my commits can be built.
  • confirmed that my code does not cause performance regressions (e.g., by running the Quake benchmark).
  • added unit tests where applicable to prove the correctness of my code and to avoid future regressions.
  • made corresponding changes to the documentation or the website according to the documentation guidelines.
  • locally verified my website or documentation changes.

@weirddan455 weirddan455 added the upstream sync Updates our code against upstream changes label Oct 17, 2023
@weirddan455 weirddan455 requested a review from kcgen October 17, 2023 12:30
@weirddan455 weirddan455 self-assigned this Oct 17, 2023
@weirddan455
Copy link
Collaborator Author

Pushed another commit to fix unused parameter warnings. There were several empty functions with just an assert so they generated warnings in release build. [[maybe_unused]] is not available since this is a C file (it just generated another warning) so I used a macro instead.

@kcgen
Copy link
Member

kcgen commented Oct 17, 2023

Excellent to see YM1728B_emu merged the PR from Staging; and these additions are more good stuff along the same lines :-)
Thanks, @weirddan455 !

@kcgen kcgen merged commit 96d1300 into main Oct 17, 2023
@weirddan455 weirddan455 deleted the wd/yamaha branch October 17, 2023 16:09
@johnnovak johnnovak added the audio Audio related issues or enhancements label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio Audio related issues or enhancements upstream sync Updates our code against upstream changes
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants