Skip to content

Fix drive automounts #3038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 22, 2023
Merged

Fix drive automounts #3038

merged 3 commits into from
Oct 22, 2023

Conversation

kcgen
Copy link
Member

@kcgen kcgen commented Oct 22, 2023 •
edited
Loading

Description

Fixes drive automounts not working, as well as allowing drive verbosity to show output (or not). Both are recent regressions.

Related issues

Manual testing

Confirmed it fixes #3037 following reproduction steps:

2023-10-22_01-01

Also confirmed path, label, and verbose drive conf settings are working:

2023-10-22_01-14

Tested with sanitizer and debug builds without issues.

Regression tested various CLI flags, include dosbox FOOBAR.EXE and -c statements.

Checklist

Please tick the items as you have addressed them. Don't remove items; leave the ones that are not applicable unchecked.

I have:

  • followed the project's contributing guidelines and code of conduct.
  • performed a self-review of my code.
  • commented on the particularly hard-to-understand areas of my code.
  • split my work into well-defined, bisectable commits, and I named my commits well.
  • applied the appropriate labels (bug, enhancement, refactoring, documentation, etc.)
  • checked that all my commits can be built.
  • confirmed that my code does not cause performance regressions (e.g., by running the Quake benchmark).
  • added unit tests where applicable to prove the correctness of my code and to avoid future regressions.
  • made corresponding changes to the documentation or the website according to the documentation guidelines.
  • locally verified my website or documentation changes.

kcgen added 3 commits October 22, 2023 00:11
@kcgen
Use !empty() in place of length() in automount routines
7911aed 
Just a style change.
@kcgen
Include a space after the drive letter when automounting
e1e1f21
@kcgen
Fix handling of automount drive conf's verbose setting
710a741 
Passes the verbosity boolean back to use the new
ToNul ( "> NUL") constant in the shell code, which
de-dupes this string from the parser.
@kcgen kcgen requested a review from FeralChild64 October 22, 2023 08:19
@kcgen kcgen self-assigned this Oct 22, 2023
@kcgen kcgen changed the title Kc/fix automount 1 Fix drive automounts Oct 22, 2023
@kcgen kcgen requested a review from weirddan455 October 22, 2023 08:21
@kcgen kcgen added the regression We broke something 😊 label Oct 22, 2023
@kcgen kcgen merged commit 6e534ac into main Oct 22, 2023
@kcgen kcgen deleted the kc/fix-automount-1 branch October 27, 2023 15:02
@Grounded0 Grounded0 mentioned this pull request Nov 17, 2023
Closed
4 tasks
@johnnovak johnnovak added the DOS Issues related to DOS integration or DOS commands label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FeralChild64 FeralChild64 FeralChild64 approved these changes

@weirddan455 weirddan455 Awaiting requested review from weirddan455

Assignees

@kcgen kcgen

Labels
DOS Issues related to DOS integration or DOS commands regression We broke something 😊
Projects
No open projects
0.81 Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drives/[letter] automounts aren't being mounted
3 participants
@kcgen @FeralChild64 @johnnovak