-
Notifications
You must be signed in to change notification settings - Fork 9.2k
[media-library][android] Remove promises #38301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The Pull Request introduced fingerprint changes against the base commit: 7fc93f6 Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-media-library/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "7dd24d67b7aed535107f6991fe0de1cd0498874c"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-media-library/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "df85207126c9d994d06b387d54b9f030a816af14"
}
}
] Generated by PR labeler 🤖 |
Subscribed to pull request
Generated by CodeMention |
...ges/expo-media-library/android/src/main/java/expo/modules/medialibrary/MediaLibraryModule.kt
Outdated
Show resolved
Hide resolved
...ages/expo-media-library/android/src/main/java/expo/modules/medialibrary/albums/AlbumUtils.kt
Outdated
Show resolved
Hide resolved
...ges/expo-media-library/android/src/main/java/expo/modules/medialibrary/albums/CreateAlbum.kt
Outdated
Show resolved
Hide resolved
packages/expo-media-library/android/src/main/java/expo/modules/medialibrary/albums/GetAlbums.kt
Outdated
Show resolved
Hide resolved
...ages/expo-media-library/android/src/main/java/expo/modules/medialibrary/assets/AssetUtils.kt
Outdated
Show resolved
Hide resolved
...ges/expo-media-library/android/src/main/java/expo/modules/medialibrary/assets/CreateAsset.kt
Outdated
Show resolved
Hide resolved
...po-media-library/android/src/main/java/expo/modules/medialibrary/contracts/DeleteContract.kt
Outdated
Show resolved
Hide resolved
packages/expo-media-library/android/src/main/java/expo/modules/medialibrary/Exceptions.kt
Show resolved
Hide resolved
...ges/expo-media-library/android/src/main/java/expo/modules/medialibrary/MediaLibraryModule.kt
Show resolved
Hide resolved
...ges/expo-media-library/android/src/main/java/expo/modules/medialibrary/MediaLibraryModule.kt
Show resolved
Hide resolved
...ges/expo-media-library/android/src/main/java/expo/modules/medialibrary/MediaLibraryModule.kt
Show resolved
Hide resolved
...ages/expo-media-library/android/src/main/java/expo/modules/medialibrary/MediaLibraryUtils.kt
Show resolved
Hide resolved
...ages/expo-media-library/android/src/main/java/expo/modules/medialibrary/albums/AlbumUtils.kt
Show resolved
Hide resolved
...ages/expo-media-library/android/src/main/java/expo/modules/medialibrary/assets/AssetUtils.kt
Show resolved
Hide resolved
packages/expo-media-library/android/src/main/java/expo/modules/medialibrary/assets/GetAssets.kt
Show resolved
Hide resolved
...po-media-library/android/src/main/java/expo/modules/medialibrary/contracts/DeleteContract.kt
Outdated
Show resolved
Hide resolved
...xpo-media-library/android/src/main/java/expo/modules/medialibrary/contracts/WriteContract.kt
Outdated
Show resolved
Hide resolved
1d9d4e2
to
00693ef
Compare
edb8fa5
to
f855a9c
Compare
1fba659
to
8ee0d90
Compare
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
…ails to load, providing clearer guidance for users. Updated the error handling logic in `resolveConfigPluginFunctionWithInfo` to include more detailed messages about the underlying errors and potential issues with the plugin reference. Added a link to the documentation for further assistance. chore: add changelog refactor: simplify error handling in plugin resolver Removed redundant error handling logic in `resolveConfigPluginFunctionWithInfo` to streamline the process of resolving config plugins. This change enhances clarity in error messaging while maintaining functionality. chore: pr nits Update error messages in plugin resolver for improved clarity and guidance. Adjusted links to documentation and refined wording for better user understanding when config plugins fail to load. nits: adjust text update text typo [background-task] Support Apple TV (#38509) Background task should work fine on tvOS, no code changes required. Modify podspec, add package to the TV compile test project. CI should pass. [background-task] Support Apple TV (#38509) Background task should work fine on tvOS, no code changes required. Modify podspec, add package to the TV compile test project. CI should pass. [ios][0.81.0] Use RN Precompiled binaries in tests (#38466) Use precompiled binaries when running tests Added to the build / pod install step in ios-unit-tests and test-suite Run tests, measure speed of iOS builds - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) Add Apple TV support to several packages (#38513) Add tvOS support to - expo-app-integrity - expo-image-loader - expo-image-manipulator - expo-insights - expo-task-manager - expo-video-thumbnails - unimodules-app-loader - Add tvOS to podspecs - One source change needed in expo-task-manager - Add packages to TV compile test project CI should pass <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) [symbols][Android] Suppress `the native view manager isn't exported` warning (#38504) [dev-launcher][android] Update floating action button icon and label (#38501) [dev-menu][android] Update floating action button design (#38497) [expo][Android] Run `spotlessApply` [media-library][android] Rewrite getAssetsAsync to Coroutines (#38193) [media-library][android] Refactor requiring permissions (#38226) chore(tools): Ratchet up dependencies checks (`@expo/image-utils`, expo-asset, expo-image, expo-video, expo-audio) (#38182) chore(tools): Disallow importing `metro` and `metro-*` in dependencies checks (#38289) [media-library][android] Remove promises (#38301) [docs] Fix grammar in useFocusEffect example in Router reference(#38515) [Docs] Update typed-routes.mdx (#34143) Co-authored-by: Aman Mittal <[email protected]> [docs] fix expo-navigation-bar example import (#38526) [media-library][android] Refactor `MediaLibraryModule` (#38324) [cli] prebuild only the platforms specified in app.json (#31752) Fixes #18386. Expo prebuild was being run for a platform even if the platform is not specified in `platforms` field of `app.json`. Now prebuild will ignore platforms which are not present in `app.json`. <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> Added a filter to exclude platforms not present in app.json before proceeding with the prebuild process. The following scenarios were tested to verify the changes: 1. With `"platforms": ["ios"]` in `app.json`: a. Running `npx expo prebuild` only executes prebuild for iOS. b. Running `npx expo prebuild -p android` skips prebuild and displays a warning. 2. With `"platforms": ["android"]` in `app.json`: a. Running `npx expo prebuild` only executes prebuild for Android. b. Running `npx expo prebuild -p ios` skips prebuild and displays a warning. 3. Without `platforms` field in `app.json`: a. Running `npx expo prebuild` executes prebuild for all platforms. <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Vojtech Novak <[email protected]> [tools][promote-packages] Assign sdk-xx tag when promoting bare-minimum (#38490) SDK tag (`sdk-xx`) on `expo-template-bare-minimum` is really important. Assign sdk-xx tag when promoting bare-minimum template. [tools][pp] clean templates and improve logs (#38491) I've setup a local npm registry to test #37366 without `--dry` and noticed some small issues. * Improve `addTemplateTarball` logs * Add templates to `cleanWorkingTree` `et pp` Bump react-native-worklets to 0.4.1 (#38469) [media-library][android] Add context and ensureActivity to suspend functions (#38373) [templates] Add tabs react navigation template (#38212) Closes https://linear.app/expo/issue/ENG-15261/create-react-navigation-version-of-starter-current-template From our default template, I took: components, hooks, screens, and adapted to use React Navigation. I ran the template locally and made sure it looked identical to our default template. I changed the export router text on the screens and also ensured that it ran on the web and was responsive to dark mode. - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) fix(expo-modules-core): Add missing peers (react/react-native) (#38528) Both are depended on by `expo-modules-core` and are referenced in their code (not only as types). We should add them as peers. This shouldn't have any unexpected consequences since both are expected to be project root dependencies. - Add missing peer dependencies - Update dependencies check - `yarn pack` - Add resolution test project - Install with pnpm (isolated, and non-isolated), Install with Yarn - Observe if dependencies are duplicated or misaligned after a fresh install <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) [go][android] Update design of the floating action button in the old dev menu (#38500) Co-authored-by: lukmccall <[email protected]> fix: snapshots
…ails to load, providing clearer guidance for users. Updated the error handling logic in `resolveConfigPluginFunctionWithInfo` to include more detailed messages about the underlying errors and potential issues with the plugin reference. Added a link to the documentation for further assistance. chore: add changelog refactor: simplify error handling in plugin resolver Removed redundant error handling logic in `resolveConfigPluginFunctionWithInfo` to streamline the process of resolving config plugins. This change enhances clarity in error messaging while maintaining functionality. chore: pr nits Update error messages in plugin resolver for improved clarity and guidance. Adjusted links to documentation and refined wording for better user understanding when config plugins fail to load. nits: adjust text update text typo [background-task] Support Apple TV (#38509) Background task should work fine on tvOS, no code changes required. Modify podspec, add package to the TV compile test project. CI should pass. [background-task] Support Apple TV (#38509) Background task should work fine on tvOS, no code changes required. Modify podspec, add package to the TV compile test project. CI should pass. [ios][0.81.0] Use RN Precompiled binaries in tests (#38466) Use precompiled binaries when running tests Added to the build / pod install step in ios-unit-tests and test-suite Run tests, measure speed of iOS builds - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) Add Apple TV support to several packages (#38513) Add tvOS support to - expo-app-integrity - expo-image-loader - expo-image-manipulator - expo-insights - expo-task-manager - expo-video-thumbnails - unimodules-app-loader - Add tvOS to podspecs - One source change needed in expo-task-manager - Add packages to TV compile test project CI should pass <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) [symbols][Android] Suppress `the native view manager isn't exported` warning (#38504) [dev-launcher][android] Update floating action button icon and label (#38501) [dev-menu][android] Update floating action button design (#38497) [expo][Android] Run `spotlessApply` [media-library][android] Rewrite getAssetsAsync to Coroutines (#38193) [media-library][android] Refactor requiring permissions (#38226) chore(tools): Ratchet up dependencies checks (`@expo/image-utils`, expo-asset, expo-image, expo-video, expo-audio) (#38182) chore(tools): Disallow importing `metro` and `metro-*` in dependencies checks (#38289) [media-library][android] Remove promises (#38301) [docs] Fix grammar in useFocusEffect example in Router reference(#38515) [Docs] Update typed-routes.mdx (#34143) Co-authored-by: Aman Mittal <[email protected]> [docs] fix expo-navigation-bar example import (#38526) [media-library][android] Refactor `MediaLibraryModule` (#38324) [cli] prebuild only the platforms specified in app.json (#31752) Fixes #18386. Expo prebuild was being run for a platform even if the platform is not specified in `platforms` field of `app.json`. Now prebuild will ignore platforms which are not present in `app.json`. <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> Added a filter to exclude platforms not present in app.json before proceeding with the prebuild process. The following scenarios were tested to verify the changes: 1. With `"platforms": ["ios"]` in `app.json`: a. Running `npx expo prebuild` only executes prebuild for iOS. b. Running `npx expo prebuild -p android` skips prebuild and displays a warning. 2. With `"platforms": ["android"]` in `app.json`: a. Running `npx expo prebuild` only executes prebuild for Android. b. Running `npx expo prebuild -p ios` skips prebuild and displays a warning. 3. Without `platforms` field in `app.json`: a. Running `npx expo prebuild` executes prebuild for all platforms. <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Vojtech Novak <[email protected]> [tools][promote-packages] Assign sdk-xx tag when promoting bare-minimum (#38490) SDK tag (`sdk-xx`) on `expo-template-bare-minimum` is really important. Assign sdk-xx tag when promoting bare-minimum template. [tools][pp] clean templates and improve logs (#38491) I've setup a local npm registry to test #37366 without `--dry` and noticed some small issues. * Improve `addTemplateTarball` logs * Add templates to `cleanWorkingTree` `et pp` Bump react-native-worklets to 0.4.1 (#38469) [media-library][android] Add context and ensureActivity to suspend functions (#38373) [templates] Add tabs react navigation template (#38212) Closes https://linear.app/expo/issue/ENG-15261/create-react-navigation-version-of-starter-current-template From our default template, I took: components, hooks, screens, and adapted to use React Navigation. I ran the template locally and made sure it looked identical to our default template. I changed the export router text on the screens and also ensured that it ran on the web and was responsive to dark mode. - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) fix(expo-modules-core): Add missing peers (react/react-native) (#38528) Both are depended on by `expo-modules-core` and are referenced in their code (not only as types). We should add them as peers. This shouldn't have any unexpected consequences since both are expected to be project root dependencies. - Add missing peer dependencies - Update dependencies check - `yarn pack` - Add resolution test project - Install with pnpm (isolated, and non-isolated), Install with Yarn - Observe if dependencies are duplicated or misaligned after a fresh install <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) [go][android] Update design of the floating action button in the old dev menu (#38500) Co-authored-by: lukmccall <[email protected]> fix: snapshots
…ails to load, providing clearer guidance for users. Updated the error handling logic in `resolveConfigPluginFunctionWithInfo` to include more detailed messages about the underlying errors and potential issues with the plugin reference. Added a link to the documentation for further assistance. chore: add changelog refactor: simplify error handling in plugin resolver Removed redundant error handling logic in `resolveConfigPluginFunctionWithInfo` to streamline the process of resolving config plugins. This change enhances clarity in error messaging while maintaining functionality. chore: pr nits Update error messages in plugin resolver for improved clarity and guidance. Adjusted links to documentation and refined wording for better user understanding when config plugins fail to load. nits: adjust text update text typo [background-task] Support Apple TV (#38509) Background task should work fine on tvOS, no code changes required. Modify podspec, add package to the TV compile test project. CI should pass. [background-task] Support Apple TV (#38509) Background task should work fine on tvOS, no code changes required. Modify podspec, add package to the TV compile test project. CI should pass. [ios][0.81.0] Use RN Precompiled binaries in tests (#38466) Use precompiled binaries when running tests Added to the build / pod install step in ios-unit-tests and test-suite Run tests, measure speed of iOS builds - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) Add Apple TV support to several packages (#38513) Add tvOS support to - expo-app-integrity - expo-image-loader - expo-image-manipulator - expo-insights - expo-task-manager - expo-video-thumbnails - unimodules-app-loader - Add tvOS to podspecs - One source change needed in expo-task-manager - Add packages to TV compile test project CI should pass <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) [symbols][Android] Suppress `the native view manager isn't exported` warning (#38504) [dev-launcher][android] Update floating action button icon and label (#38501) [dev-menu][android] Update floating action button design (#38497) [expo][Android] Run `spotlessApply` [media-library][android] Rewrite getAssetsAsync to Coroutines (#38193) [media-library][android] Refactor requiring permissions (#38226) chore(tools): Ratchet up dependencies checks (`@expo/image-utils`, expo-asset, expo-image, expo-video, expo-audio) (#38182) chore(tools): Disallow importing `metro` and `metro-*` in dependencies checks (#38289) [media-library][android] Remove promises (#38301) [docs] Fix grammar in useFocusEffect example in Router reference(#38515) [Docs] Update typed-routes.mdx (#34143) Co-authored-by: Aman Mittal <[email protected]> [docs] fix expo-navigation-bar example import (#38526) [media-library][android] Refactor `MediaLibraryModule` (#38324) [cli] prebuild only the platforms specified in app.json (#31752) Fixes #18386. Expo prebuild was being run for a platform even if the platform is not specified in `platforms` field of `app.json`. Now prebuild will ignore platforms which are not present in `app.json`. <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> Added a filter to exclude platforms not present in app.json before proceeding with the prebuild process. The following scenarios were tested to verify the changes: 1. With `"platforms": ["ios"]` in `app.json`: a. Running `npx expo prebuild` only executes prebuild for iOS. b. Running `npx expo prebuild -p android` skips prebuild and displays a warning. 2. With `"platforms": ["android"]` in `app.json`: a. Running `npx expo prebuild` only executes prebuild for Android. b. Running `npx expo prebuild -p ios` skips prebuild and displays a warning. 3. Without `platforms` field in `app.json`: a. Running `npx expo prebuild` executes prebuild for all platforms. <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Vojtech Novak <[email protected]> [tools][promote-packages] Assign sdk-xx tag when promoting bare-minimum (#38490) SDK tag (`sdk-xx`) on `expo-template-bare-minimum` is really important. Assign sdk-xx tag when promoting bare-minimum template. [tools][pp] clean templates and improve logs (#38491) I've setup a local npm registry to test #37366 without `--dry` and noticed some small issues. * Improve `addTemplateTarball` logs * Add templates to `cleanWorkingTree` `et pp` Bump react-native-worklets to 0.4.1 (#38469) [media-library][android] Add context and ensureActivity to suspend functions (#38373) [templates] Add tabs react navigation template (#38212) Closes https://linear.app/expo/issue/ENG-15261/create-react-navigation-version-of-starter-current-template From our default template, I took: components, hooks, screens, and adapted to use React Navigation. I ran the template locally and made sure it looked identical to our default template. I changed the export router text on the screens and also ensured that it ran on the web and was responsive to dark mode. - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) fix(expo-modules-core): Add missing peers (react/react-native) (#38528) Both are depended on by `expo-modules-core` and are referenced in their code (not only as types). We should add them as peers. This shouldn't have any unexpected consequences since both are expected to be project root dependencies. - Add missing peer dependencies - Update dependencies check - `yarn pack` - Add resolution test project - Install with pnpm (isolated, and non-isolated), Install with Yarn - Observe if dependencies are duplicated or misaligned after a fresh install <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) [go][android] Update design of the floating action button in the old dev menu (#38500) Co-authored-by: lukmccall <[email protected]> fix: snapshots
Why
Depends on #38226, which aims to rewrite the
MediaLibrary
module to be coroutine-based.How
runActionWithPermissions
to return a value instead of just triggering an intent.In order to remove
Promise
usage from functions relying onrunActionWithPermissions
, it was necessary to makerunActionWithPermissions
return a value, instead of just running an intent.Was:
save action -> run intent -> handle result and execute saved action in OnActivityResult
Is:
register launcher using RegisterActivityContract -> launch it as a suspendable function within runActionWithPermissions
promise.reject
usages withCodedException
Promise
.initializeDefaultAssetsAsync
in the TS tests to make the logic more verbose.moduleCoroutineScope
, and replaced its usage with theCoroutine
annotation in theAsyncFunction
declarations.Test Plan
Tested on BareExpo ✅