rRename get_my_teams to get_teams and update documentation and tests

mattdholloway · mattdholloway · commit 8ebb8340918d · 2025-08-08T16:37:07.000+01:00
diff --git a/README.md b/README.md
@@ -421,8 +421,8 @@ The following sets of tools are available (all are on by default):
 - **get_me** - Get my user profile
   - No parameters required
 
-- **get_my_teams** - Get my teams
-  - No parameters required
+- **get_teams** - Get my teams
+  - `user`: Username to get teams for. If not provided, uses the authenticated user. (string, optional)
 
 </details>
 
diff --git a/pkg/github/__toolsnaps__/get_teams.snap b/pkg/github/__toolsnaps__/get_teams.snap
@@ -0,0 +1,17 @@
+{
+  "annotations": {
+    "title": "Get my teams",
+    "readOnlyHint": true
+  },
+  "description": "Get details of the teams the authenticated user is a member of.",
+  "inputSchema": {
+    "properties": {
+      "user": {
+        "description": "Username to get teams for. If not provided, uses the authenticated user.",
+        "type": "string"
+      }
+    },
+    "type": "object"
+  },
+  "name": "get_teams"
+}
diff --git a/pkg/github/context_tools.go b/pkg/github/context_tools.go
@@ -93,14 +93,14 @@ func GetMe(getClient GetClientFn, t translations.TranslationHelperFunc) (mcp.Too
 	return tool, handler
 }
 
-func GetMyTeams(getClient GetClientFn, getGQLClient GetGQLClientFn, t translations.TranslationHelperFunc) (mcp.Tool, server.ToolHandlerFunc) {
-	tool := mcp.NewTool("get_my_teams",
-		mcp.WithDescription(t("TOOL_GET_MY_TEAMS_DESCRIPTION", "Get details of the teams the authenticated user is a member of.")),
+func GetTeams(getClient GetClientFn, getGQLClient GetGQLClientFn, t translations.TranslationHelperFunc) (mcp.Tool, server.ToolHandlerFunc) {
+	tool := mcp.NewTool("get_teams",
+		mcp.WithDescription(t("TOOL_GET_TEAMS_DESCRIPTION", "Get details of the teams the authenticated user is a member of.")),
 		mcp.WithString("user",
-			mcp.Description(t("TOOL_GET_MY_TEAMS_USER_DESCRIPTION", "Username to get teams for. If not provided, uses the authenticated user.")),
+			mcp.Description(t("TOOL_GET_TEAMS_USER_DESCRIPTION", "Username to get teams for. If not provided, uses the authenticated user.")),
 		),
 		mcp.WithToolAnnotation(mcp.ToolAnnotation{
-			Title:        t("TOOL_GET_MY_TEAMS_TITLE", "Get my teams"),
+			Title:        t("TOOL_GET_TEAMS_TITLE", "Get my teams"),
 			ReadOnlyHint: ToBoolPtr(true),
 		}),
 	)
diff --git a/pkg/github/context_tools_test.go b/pkg/github/context_tools_test.go
@@ -143,14 +143,14 @@ func Test_GetMe(t *testing.T) {
 	}
 }
 
-func Test_GetMyTeams(t *testing.T) {
+func Test_GetTeams(t *testing.T) {
 	t.Parallel()
 
-	tool, _ := GetMyTeams(nil, nil, translations.NullTranslationHelper)
+	tool, _ := GetTeams(nil, nil, translations.NullTranslationHelper)
 	require.NoError(t, toolsnaps.Test(tool.Name, tool))
 
-	assert.Equal(t, "get_my_teams", tool.Name)
-	assert.True(t, *tool.Annotations.ReadOnlyHint, "get_my_teams tool should be read-only")
+	assert.Equal(t, "get_teams", tool.Name)
+	assert.True(t, *tool.Annotations.ReadOnlyHint, "get_teams tool should be read-only")
 
 	mockUser := &github.User{
 		Login:           github.Ptr("testuser"),
@@ -333,7 +333,7 @@ func Test_GetMyTeams(t *testing.T) {
 
 	for _, tc := range tests {
 		t.Run(tc.name, func(t *testing.T) {
-			_, handler := GetMyTeams(tc.stubbedGetClientFn, tc.stubbedGetGQLClientFn, translations.NullTranslationHelper)
+			_, handler := GetTeams(tc.stubbedGetClientFn, tc.stubbedGetGQLClientFn, translations.NullTranslationHelper)
 
 			request := createMCPRequest(tc.requestArgs)
 			result, err := handler(context.Background(), request)
diff --git a/pkg/github/tools.go b/pkg/github/tools.go
@@ -162,7 +162,7 @@ func DefaultToolsetGroup(readOnly bool, getClient GetClientFn, getGQLClient GetG
 	contextTools := toolsets.NewToolset("context", "Tools that provide context about the current user and GitHub context you are operating in").
 		AddReadTools(
 			toolsets.NewServerTool(GetMe(getClient, t)),
-			toolsets.NewServerTool(GetMyTeams(getClient, getGQLClient, t)),
+			toolsets.NewServerTool(GetTeams(getClient, getGQLClient, t)),
 		)
 
 	gists := toolsets.NewToolset("gists", "GitHub Gist related tools").

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ func DefaultToolsetGroup(readOnly bool, getClient GetClientFn, getGQLClient GetG`
`162`	`162`	`contextTools := toolsets.NewToolset("context", "Tools that provide context about the current user and GitHub context you are operating in").`
`163`	`163`	`AddReadTools(`
`164`	`164`	`toolsets.NewServerTool(GetMe(getClient, t)),`
`165`		`- toolsets.NewServerTool(GetMyTeams(getClient, getGQLClient, t)),`
	`165`	`+ toolsets.NewServerTool(GetTeams(getClient, getGQLClient, t)),`
`166`	`166`	`)`
`167`	`167`
`168`	`168`	`gists := toolsets.NewToolset("gists", "GitHub Gist related tools").`