-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
My model did not have the owner
of the repo - but still called create_pending_pull_request_review
and submit_pending_pull_request_review
for a fake owner of gemma-exts
. The tool calls were determined successful - but should be considered failures (gemma-exts/run-gemini-cli
is not a real repo).
Full function args:
{
"pullNumber": 3,
"owner": "gemma-exts",
"repo": "run-gemini-cli"
}
Affected version
Not sure how to run this command within the github action, since another action spins up the server, but the server configuration is:
"mcpServers": {
"github": {
"command": "docker",
"args": [
"run",
"-i",
"--rm",
"-e",
"GITHUB_PERSONAL_ACCESS_TOKEN",
"ghcr.io/github/github-mcp-server"
],
"includeTools": [
"create_pending_pull_request_review",
"add_comment_to_pending_review",
"submit_pending_pull_request_review"
],
"env": {
"GITHUB_PERSONAL_ACCESS_TOKEN": "${GITHUB_TOKEN}"
}
}
},
Steps to reproduce the behavior
Call the create_pending_pull_request_review
with a fake repo
Make an MCP request to a fake repo, example:
{
"pullNumber": 3,
"owner": "gemma-exts",
"repo": "run-gemini-cli"
}
Expected vs actual behavior
An error should be surface
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working