Skip to content

Commit 2b6db00

Browse files
authored
Merge pull request #575 from tamer1an/#569-tamer1an-fix-requestAllPages
#569 tamer1an fix for get all pages in _requestAllPages
2 parents bf3a408 + 86775a6 commit 2b6db00

File tree

1 file changed

+14
-3
lines changed

1 file changed

+14
-3
lines changed

lib/Requestable.js

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -256,9 +256,20 @@ class Requestable {
256256
results.push(...thisGroup);
257257

258258
const nextUrl = getNextPage(response.headers.link);
259-
if (nextUrl && !(options && typeof options.page !== 'number')) {
260-
log(`getting next page: ${nextUrl}`);
261-
return this._requestAllPages(nextUrl, options, cb, results);
259+
if(nextUrl) {
260+
if (!options) {
261+
options = {};
262+
}
263+
options.page = parseInt(
264+
nextUrl.match(/(page=[0-9]*)/g)
265+
.shift()
266+
.split('=')
267+
.pop()
268+
);
269+
if (!(options && typeof options.page !== 'number')) {
270+
log(`getting next page: ${nextUrl}`);
271+
return this._requestAllPages(nextUrl, options, cb, results);
272+
}
262273
}
263274

264275
if (cb) {

0 commit comments

Comments
 (0)