fix(repository): prevents lib from crashing when not providing optional arguments

hazmah0 · hazmah0 · commit eb2b4f311c2d · 2019-09-19T21:30:55.000+02:00
diff --git a/lib/Repository.js b/lib/Repository.js
@@ -749,6 +749,7 @@ class Repository extends Requestable {
     * @return {Promise} - the promise for the http request
     */
    writeFile(branch, path, content, message, options, cb) {
+      options = options || {};
       if (typeof options === 'function') {
          cb = options;
          options = {};
diff --git a/test/repository.spec.js b/test/repository.spec.js
@@ -385,6 +385,17 @@ describe('Repository', function() {
          }));
       });
 
+      it('should successfully write to repo when not providing optional options argument', function(done) {
+         remoteRepo.writeFile('master', fileName, initialText, initialMessage, undefined, assertSuccessful(done, function() {
+            wait()().then(() => remoteRepo.getContents('master', fileName, 'raw',
+               assertSuccessful(done, function(err, fileText) {
+                  expect(fileText).to.be(initialText);
+
+                  done();
+               })));
+         }));
+      });
+
       it('should rename files', function(done) {
          remoteRepo.writeFile('master', fileName, initialText, initialMessage, assertSuccessful(done, function() {
             wait()().then(() => remoteRepo.move('master', fileName, 'new_name', assertSuccessful(done, function() {
