fix: missing type_traits include
#1824
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
same problem here, it happens when I switch from '-std=c++20' to '-std=c++23' btw, should it be merged into branch 4.4 also ? |
Ivorforce
approved these changes
Aug 4, 2025
dsnopek
approved these changes
Aug 4, 2025
There was a problem hiding this comment.
Thanks!
However, in order to be merged, this will need to be squashed into a single commit, per Godot's pull request workflow:
https://docs.godotengine.org/en/latest/contributing/workflow/pr_workflow.html#the-interactive-rebase
Usage of `std::is_trivially_constructible` in `defs.hpp` requires including `type_traits`. This missing include leads to errors about that type not being found when building with clang++-22 with libc++-22.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of
std::is_trivially_constructibleindefs.hpprequires includingtype_traits.This missing include leads to errors about that type not being found when building with clang++-22 with libc++-22 (which are not released yet), probably they changed the other header's transitive dependencies, making the issue suddenly visible.