Don't use custom header for Deployment requests

rweald · rweald · commit f79febba48c8 · 2014-12-01T15:44:34.000-08:00
diff --git a/AUTHORS.rst b/AUTHORS.rst
@@ -82,3 +82,5 @@ Contributors
 - Adrian Moisey (@adrianmoisey)
 
 - Bryce Boe (@bboe)
+
+- Ryan Weald (@rweald)
diff --git a/github3/repos/deployment.py b/github3/repos/deployment.py
@@ -6,10 +6,6 @@
 
 
 class Deployment(GitHubCore):
-    CUSTOM_HEADERS = {
-        'Accept': 'application/vnd.github.cannonball-preview+json'
-        }
-
     def _update_attributes(self, deployment):
         self._api = deployment.get('url')
 
@@ -67,8 +63,7 @@ def create_status(self, state, target_url=None, description=None):
             data = {'state': state, 'target_url': target_url,
                     'description': description}
             self._remove_none(data)
-            response = self._post(self.statuses_url, data=data,
-                                  headers=Deployment.CUSTOM_HEADERS)
+            response = self._post(self.statuses_url, data=data)
             json = self._json(response, 201)
 
         return self._instance_or_null(DeploymentStatus, json)
@@ -84,7 +79,6 @@ def statuses(self, number=-1, etag=None):
         """
         i = self._iter(int(number), self.statuses_url, DeploymentStatus,
                        etag=etag)
-        i.headers = Deployment.CUSTOM_HEADERS
         return i
 
 
diff --git a/github3/repos/repo.py b/github3/repos/repo.py
@@ -724,8 +724,7 @@ def create_deployment(self, ref, force=False, payload='',
                     'auto_merge': auto_merge, 'description': description,
                     'environment': environment}
             self._remove_none(data)
-            headers = Deployment.CUSTOM_HEADERS
-            json = self._json(self._post(url, data=data, headers=headers),
+            json = self._json(self._post(url, data=data),
                               201)
         return self._instance_or_null(Deployment, json)
 
@@ -1091,7 +1090,6 @@ def deployments(self, number=-1, etag=None):
         """
         url = self._build_url('deployments', base_url=self._api)
         i = self._iter(int(number), url, Deployment, etag=etag)
-        i.headers.update(Deployment.CUSTOM_HEADERS)
         return i
 
     @requires_auth
diff --git a/tests/unit/test_repos_deployment.py b/tests/unit/test_repos_deployment.py
@@ -64,7 +64,5 @@ def test_statuses(self):
         self.session.get.assert_called_once_with(
             url_for('statuses'),
             params={'per_page': 100},
-            headers={
-                'Accept': 'application/vnd.github.cannonball-preview+json'
-            }
+            headers={}
         )
diff --git a/tests/unit/test_repos_repo.py b/tests/unit/test_repos_repo.py
@@ -384,9 +384,7 @@ def test_deployments(self):
         self.session.get.assert_called_once_with(
             url_for('deployments'),
             params={'per_page': 100},
-            headers={
-                'Accept': 'application/vnd.github.cannonball-preview+json'
-            }
+            headers={}
         )
 
     def test_events(self):

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,5 @@ def test_statuses(self):`
`64`	`64`	`self.session.get.assert_called_once_with(`
`65`	`65`	`url_for('statuses'),`
`66`	`66`	`params={'per_page': 100},`
`67`		`- headers={`
`68`		`- 'Accept': 'application/vnd.github.cannonball-preview+json'`
`69`		`- }`
	`67`	`+ headers={}`
`70`	`68`	`)`