feat: add flag for gapic metadata #795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
software-dov
requested review from
a team,
arithmetic1728,
busunkim96 and
vchudnov-g
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #795 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 27 +1
Lines 1608 1649 +41
Branches 328 337 +9
=========================================
+ Hits 1608 1649 +41
Continue to review full report at Codecov.
|
As per the design doc, gapic metadata should not be generated by default, and should be gated by the 'metadata' flag. When invoking the generator via protoc, toggle the metadata flag like so: --python_gapic_opt="metadata" Subsequent Bazel integration is WIP.
software-dov
force-pushed
the
metadata-flag-pick
branch
from
c2e36ba to
e0c781c
Compare
vchudnov-g
approved these changes
Mar 3, 2021
software-dov
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the design doc, gapic metadata should not be generated by
default, and should be gated by the 'metadata' flag.
When invoking the generator via protoc, toggle the metadata flag like so:
--python_gapic_opt="metadata"
Subsequent Bazel integration is WIP.