fix: Fix handling of null responses in rest transport#1668
fix: Fix handling of null responses in rest transport#1668vam-google merged 2 commits intogoogleapis:mainfrom
Conversation
Null response should not ever happen, but apparently it is possible in cases when errors occur somewhere on network/authentication level
vam-google
changed the title
| statusCode, | ||
| "Exception during a client call closure", | ||
| new NullPointerException( | ||
| "Both response message and response exception were null"))); |
There was a problem hiding this comment.
I think this message should be "Either response message or response exception is null"?
There was a problem hiding this comment.
It should mean that both of them are null (i.e. and not or). One of them being null is Ok. Either one being null has been handled before. Specifically !future.isDone() means that there was no response message (null), trailers.getException() == null means that there was no excepiton either. I did not even think it was poissible combination, but apparently it is possible for a super-broken responses from server.
There was a problem hiding this comment.
Got it, so both check trailers == null and trailers.getException() == null are checking if the response exception exist or not. Yeah I found similar things when I was implementing the Error Details feature, where I checked both trailer and trailer error.
|
Kudos, SonarCloud Quality Gate passed! |
🤖 I have created a release *beep* *boop* --- ## [2.17.0](v2.16.0...v2.17.0) (2022-05-10) ### Features * next release from main branch is 2.17.0 ([#1659](#1659)) ([5a31361](5a31361)) ### Bug Fixes * Fix handling of null responses in rest transport ([#1668](#1668)) ([8def947](8def947)) * use graal-sdk 21.3.2 ([#1670](#1670)) ([92c2697](92c2697)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [2.17.0](googleapis/gax-java@v2.16.0...v2.17.0) (2022-05-10) ### Features * next release from main branch is 2.17.0 ([#1659](googleapis/gax-java#1659)) ([475b57b](googleapis/gax-java@475b57b)) ### Bug Fixes * Fix handling of null responses in rest transport ([#1668](googleapis/gax-java#1668)) ([49c6d70](googleapis/gax-java@49c6d70)) * use graal-sdk 21.3.2 ([#1670](googleapis/gax-java#1670)) ([ac55789](googleapis/gax-java@ac55789)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
2 participants
Null response should not ever happen, but apparently it is possible in cases when errors occur somewhere on network/authentication level