Skip to content

fix: removes AWS credential source validation.#1177

Merged
lsirac merged 1 commit intogoogleapis:mainfrom
lsirac:aws
Mar 6, 2023
Merged

fix: removes AWS credential source validation.#1177
lsirac merged 1 commit intogoogleapis:mainfrom
lsirac:aws

Conversation

@lsirac
Copy link
Contributor

@lsirac lsirac commented Mar 2, 2023

Removes the changes introduced by #1079.

@lsirac lsirac requested a review from a team as a code owner March 2, 2023 01:22
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 2, 2023
@lsirac lsirac requested a review from aeitzman March 2, 2023 01:23
@lsirac lsirac added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 2, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 2, 2023
Copy link

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe also mention it in readme? Like previous removed validations

@TimurSadykov TimurSadykov added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Mar 2, 2023
@lsirac lsirac merged commit 77a99c9 into googleapis:main Mar 6, 2023
@lsirac lsirac deleted the aws branch March 6, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants