fix(spanner): handle unused errors (#10067)

egonelbre · web-flow · commit a0c097c724b6 · 2024-05-03T17:00:36.000Z
The error return values were not being used. Caught by staticcheck.
diff --git a/spanner/spansql/parser.go b/spanner/spansql/parser.go
@@ -1372,6 +1372,9 @@ func (p *parser) parseCreateView() (*CreateView, *parseError) {
 		return nil, err
 	}
 	vname, err := p.parseTableOrIndexOrColumnName()
+	if err != nil {
+		return nil, err
+	}
 	if err := p.expect("SQL", "SECURITY"); err != nil {
 		return nil, err
 	}
diff --git a/spanner/test/cloudexecutor/executor/actions/admin.go b/spanner/test/cloudexecutor/executor/actions/admin.go
@@ -347,6 +347,9 @@ func executeGetCloudInstance(ctx context.Context, action *executorpb.GetCloudIns
 	instanceObj, err := instanceAdminClient.GetInstance(ctx, &instancepb.GetInstanceRequest{
 		Name: fmt.Sprintf("projects/%s/instances/%s", projectID, instanceID),
 	})
+	if err != nil {
+		return err
+	}
 	spannerActionOutcome := &executorpb.SpannerActionOutcome{
 		Status: &spb.Status{Code: int32(codes.OK)},
 		AdminResult: &executorpb.AdminResult{
diff --git a/spanner/test/cloudexecutor/executor/actions/mutation.go b/spanner/test/cloudexecutor/executor/actions/mutation.go
@@ -139,6 +139,9 @@ func createMutation(action *executorpb.MutationAction, tableMetadata *utility.Ta
 				return nil, err
 			}
 			keySet, err := utility.KeySetProtoToCloudKeySet(mod.DeleteKeys, keyColTypes)
+			if err != nil {
+				return nil, err
+			}
 			m = append(m, spanner.Delete(table, keySet))
 		default:
 			return nil, spanner.ToSpannerError(status.Errorf(codes.InvalidArgument, "unsupported mod: %s", mod.String()))

Original file line number	Diff line number	Diff line change
`@@ -1372,6 +1372,9 @@ func (p parser) parseCreateView() (CreateView, *parseError) {`
`1372`	`1372`	`return nil, err`
`1373`	`1373`	`}`
`1374`	`1374`	`vname, err := p.parseTableOrIndexOrColumnName()`
	`1375`	`+ if err != nil {`
	`1376`	`+ return nil, err`
	`1377`	`+ }`
`1375`	`1378`	`if err := p.expect("SQL", "SECURITY"); err != nil {`
`1376`	`1379`	`return nil, err`
`1377`	`1380`	`}`