Skip to content

Commit 861458c

Browse files
yoshi-automationbusunkim96
authored andcommitted
chore(billingbudgets): add comments to proto files (via synth) (#9854)
1 parent bdec5e5 commit 861458c

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

billingbudgets/google/cloud/billing_budgets_v1beta1/proto/budget_service.proto

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ service BudgetService {
4141
rpc CreateBudget(CreateBudgetRequest) returns (Budget) {
4242
option (google.api.http) = {
4343
post: "/v1beta1/{parent=billingAccounts/*}/budgets"
44+
// (-- TODO for GA: use "budget" instead of "*" to comply with
45+
// https://aip.dev/133. Changing in Beta would be a breaking change. --)
4446
body: "*"
4547
};
4648
}
@@ -49,6 +51,8 @@ service BudgetService {
4951
rpc UpdateBudget(UpdateBudgetRequest) returns (Budget) {
5052
option (google.api.http) = {
5153
patch: "/v1beta1/{budget.name=billingAccounts/*/budgets/*}"
54+
// (-- TODO for GA: use "budget" instead of "*" to comply with
55+
// https://aip.dev/134. Changing in Beta would be a breaking change. --)
5256
body: "*"
5357
};
5458
}

billingbudgets/synth.metadata

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"updateTime": "2019-11-19T13:16:42.779546Z",
2+
"updateTime": "2019-11-20T13:14:31.109994Z",
33
"sources": [
44
{
55
"generator": {
@@ -12,8 +12,8 @@
1212
"git": {
1313
"name": "googleapis",
1414
"remote": "https://github.com/googleapis/googleapis.git",
15-
"sha": "d8dd7fe8d5304f7bd1c52207703d7f27d5328c5a",
16-
"internalRef": "281088257"
15+
"sha": "16543773103e2619d2b5f52456264de5bb9be104",
16+
"internalRef": "281423227"
1717
}
1818
},
1919
{

0 commit comments

Comments
 (0)