Updating lint rules to account for new generated files.

dhermes · dhermes · commit a5cb9e3bb131 · 2016-01-14T21:18:00.000-08:00
diff --git a/scripts/pylintrc_default b/scripts/pylintrc_default
@@ -27,10 +27,8 @@
 # DEFAULT:  ignore=CVS
 # NOTE: This path must be relative due to the use of
 #       os.walk in astroid.modutils.get_module_files.
-# RATIONALE:
-#   _datastore_v1_pb2.py:   protobuf-generated code.
-ignore =
-    _datastore_v1_pb2.py
+# RATIONALE: No files to ignore.
+ignore=
 
 # Pickle collected data for later comparisons.
 # DEFAULT:  persistent=yes
diff --git a/scripts/run_pylint.py b/scripts/run_pylint.py
@@ -29,12 +29,11 @@
 
 
 IGNORED_DIRECTORIES = [
-    'gcloud/bigtable/_generated',
-    'gcloud/datastore/_generated',
+    os.path.join('gcloud', 'bigtable', '_generated'),
+    os.path.join('gcloud', 'datastore', '_generated'),
 ]
 IGNORED_FILES = [
-    'gcloud/datastore/_datastore_v1_pb2.py',
-    'docs/conf.py',
+    os.path.join('docs', 'conf.py'),
     'setup.py',
 ]
 SCRIPTS_DIR = os.path.abspath(os.path.dirname(__file__))
diff --git a/tox.ini b/tox.ini
@@ -61,7 +61,7 @@ deps = {[testenv:docs]deps}
 passenv = {[testenv:docs]passenv}
 
 [pep8]
-exclude = gcloud/datastore/_generated/*,gcloud/datastore/_datastore_v1_pb2.py,gcloud/bigtable/_generated/*,docs/conf.py,
+exclude = docs/conf.py,gcloud/bigtable/_generated/*,gcloud/datastore/_generated/*
 verbose = 1
 
 [testenv:lint]

Original file line number	Diff line number	Diff line change
`@@ -29,12 +29,11 @@`
`29`	`29`
`30`	`30`
`31`	`31`	`IGNORED_DIRECTORIES = [`
`32`		`- 'gcloud/bigtable/_generated',`
`33`		`- 'gcloud/datastore/_generated',`
	`32`	`+ os.path.join('gcloud', 'bigtable', '_generated'),`
	`33`	`+ os.path.join('gcloud', 'datastore', '_generated'),`
`34`	`34`	`]`
`35`	`35`	`IGNORED_FILES = [`
`36`		`- 'gcloud/datastore/_datastore_v1_pb2.py',`
`37`		`- 'docs/conf.py',`
	`36`	`+ os.path.join('docs', 'conf.py'),`
`38`	`37`	`'setup.py',`
`39`	`38`	`]`
`40`	`39`	`SCRIPTS_DIR = os.path.abspath(os.path.dirname(__file__))`