Skip to content
This repository was archived by the owner on Nov 29, 2023. It is now read-only.

fix: region tags in create_mysql_connection.py #205

Merged
loferris merged 2 commits into from
Apr 21, 2022
Merged

fix: region tags in create_mysql_connection.py #205

loferris merged 2 commits into from
Apr 21, 2022

Conversation

@loferris
Copy link
Contributor

@loferris loferris commented Apr 21, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)

@loferris loferris requested a review from a team as a code owner April 21, 2022 01:41
@loferris loferris requested review from a team, engelke and shollyman April 21, 2022 01:41
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 21, 2022
@snippet-bot
Copy link

snippet-bot bot commented Apr 21, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: bigqueryconnection Issues related to the googleapis/python-bigquery-connection API. label Apr 21, 2022
@loferris loferris merged commit f082fd2 into main Apr 21, 2022
@loferris loferris deleted the fix_sample_region_tags branch April 21, 2022 17:43
@release-please release-please bot mentioned this pull request Apr 21, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@engelke engelke Awaiting requested review from engelke engelke was automatically assigned from googleapis/python-samples-reviewers

1 more reviewer

@shollyman shollyman shollyman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryconnection Issues related to the googleapis/python-bigquery-connection API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@loferris @shollyman @parthea