Skip to content

fix: mimic the pubsub test to clean up bigquery datasets #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 30, 2022
Merged

fix: mimic the pubsub test to clean up bigquery datasets #639

merged 3 commits into from
Sep 30, 2022

Conversation

leahecole
Copy link
Contributor

This should fix #635

@leahecole leahecole requested review from a team as code owners September 30, 2022 14:44
@leahecole leahecole requested a review from nicain September 30, 2022 14:44
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Sep 30, 2022
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Sep 30, 2022
@leahecole leahecole changed the title mimic the pubsub test to clean up bigquery datasets fix: mimic the pubsub test to clean up bigquery datasets Sep 30, 2022
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2022
@leahecole
Copy link
Contributor Author

Tests are failing on a quota error, I'll try to rerun

@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2022
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2022
@leahecole
Copy link
Contributor Author

leahecole commented Sep 30, 2022 •
edited by dandhlee
Loading

Looking at the project in question and am not seeing anything near the quota limit 🤔

@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2022
dandhlee
dandhlee approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor nit.

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Sep 30, 2022
@leahecole leahecole merged commit 44deb1b into main Sep 30, 2022
@leahecole leahecole deleted the fix_635 branch September 30, 2022 18:45
@release-please release-please bot mentioned this pull request Sep 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

@dandhlee dandhlee dandhlee approved these changes

@nicain nicain Awaiting requested review from nicain nicain is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees

@daniel-sanche daniel-sanche

Labels
api: logging Issues related to the googleapis/python-logging API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usage guide test leaving BQ leftovers
4 participants
@leahecole @daniel-sanche @dandhlee @yoshi-kokoro