Add convertHelmertToTransform to Helmert2DWithZOffset Class #8355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dassaf4
approved these changes
Jul 28, 2025
DanRod1999
requested review from
a team,
bbastings,
aruniverse,
ColinKerr,
christophermlawson and
StefanApfel-Bentley
as code owners
aruniverse
reviewed
Jul 29, 2025
aruniverse
approved these changes
Jul 29, 2025
eringram
approved these changes
Jul 30, 2025
markschlosseratbentley
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution for: #8350
Currently a version of this method exists in my PR linked in the issue, but I don't think it makes sense for this method to exist in the imodel-transformer class.
I think this or a static method in the Transformer class makes the most sense.
Thanks to @dassaf4 helping with the math operations.