Support inputType on InputEvent

diegohaz · web-flow · commit 017568e4fbd8 · 2021-03-07T14:35:29.000-05:00
Also removes the initInputEvent method implementation, which was never exposed (and does not exist in the spec).
diff --git a/lib/jsdom/living/events/InputEvent-impl.js b/lib/jsdom/living/events/InputEvent-impl.js
@@ -1,21 +1,9 @@
 "use strict";
-
 const UIEventImpl = require("./UIEvent-impl").implementation;
-
 const InputEventInit = require("../generated/InputEventInit");
 
 // https://w3c.github.io/uievents/#interface-inputevent
-class InputEventImpl extends UIEventImpl {
-  initInputEvent(type, bubbles, cancelable, data, isComposing) {
-    if (this._dispatchFlag) {
-      return;
-    }
-
-    this.initUIEvent(type, bubbles, cancelable);
-    this.data = data;
-    this.isComposing = isComposing;
-  }
-}
+class InputEventImpl extends UIEventImpl { }
 InputEventImpl.defaultInit = InputEventInit.convert(undefined);
 
 module.exports = {
diff --git a/lib/jsdom/living/events/InputEvent.webidl b/lib/jsdom/living/events/InputEvent.webidl
@@ -5,6 +5,7 @@ interface InputEvent : UIEvent {
 
   readonly attribute DOMString? data;
   readonly attribute boolean isComposing;
+  readonly attribute DOMString inputType;
 };
 
 // https://w3c.github.io/uievents/#idl-inputeventinit
@@ -13,4 +14,5 @@ dictionary InputEventInit : UIEventInit {
   // DOMString? data = "";
   DOMString? data = null;
   boolean isComposing = false;
+  DOMString inputType = "";
 };
diff --git a/test/web-platform-tests/to-upstream/uievents/constructors/inputevent-constructor.html b/test/web-platform-tests/to-upstream/uievents/constructors/inputevent-constructor.html
@@ -0,0 +1,18 @@
+<!DOCTYPE html>
+<title>InputEvent Constructor Tests</title>
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script>
+"use strict";
+test(() => {
+  const event = new InputEvent("type");
+  assert_equals(event.data, null, ".data");
+  assert_false(event.isComposing, ".isComposing");
+  assert_equals(event.inputType, "", ".inputType");
+}, "InputEvent constructor without InputEventInit.");
+
+test(() => {
+  const event = new InputEvent("type", { inputType: "insertText" });
+  assert_equals(event.inputType, "insertText", ".inputType");
+}, "InputEvent construtor with InputEventInit where inputType is specified");
+</script>
