[12.x] Cache isSoftDeletable(), isPrunable(), and isMassPrunable() directly in model #56078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not quite sure why the tests fail all with a sudden despite not much being changed 🤔 |
|
@shaedrich not sure if this is why the tests are failing, but this doesn't work. All models will now share the same cache: class ModelA extends Model
{
use SoftDeletes;
}
class ModelB extends Model
{
}
dump(
ModelA::isSoftDeletable(),
ModelB::isSoftDeletable(),
);
// prints: true true |
Co-authored-by: Choraimy Kroonstuiver <[email protected]> See laravel#56078 (comment)
taylorotwell
added a commit
to illuminate/database
that referenced
this pull request
Jun 24, 2025
…rectly in model (#56078) * Do caching of isSoftDeletable(), isPrunable(), and isMassPrunable() directly in the model * StyleCI * Change cached boolean to map with late static binding Co-authored-by: Choraimy Kroonstuiver <[email protected]> See laravel/framework#56078 (comment) * formatting --------- Co-authored-by: Taylor Otwell <[email protected]>
mohammad-fouladgar
pushed a commit
to mohammad-fouladgar/framework
that referenced
this pull request
Jul 22, 2025
…rectly in model (laravel#56078) * Do caching of isSoftDeletable(), isPrunable(), and isMassPrunable() directly in the model * StyleCI * Change cached boolean to map with late static binding Co-authored-by: Choraimy Kroonstuiver <[email protected]> See laravel#56078 (comment) * formatting --------- Co-authored-by: Taylor Otwell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classes rarely change at runtime, however, checking their dependencies every time we need them—sometimes even recursively—can be expensive. So, caching them makes sense.
Follow-up to #56060
as suggested in #56069 (comment)